From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Sumit Gupta" <sumitg@nvidia.com>, <robh@kernel.org>,
<conor+dt@kernel.org>, <maz@kernel.org>, <mark.rutland@arm.com>,
<treding@nvidia.com>, <jonathanh@nvidia.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <amhetre@nvidia.com>,
<bbasu@nvidia.com>
Subject: Re: [Patch v3 1/2] dt-bindings: make sid and broadcast reg optional
Date: Wed, 24 Apr 2024 18:26:01 +0200 [thread overview]
Message-ID: <D0SHRQVCGJBY.2DPLX9K6VXEYM@gmail.com> (raw)
In-Reply-To: <d26f9661-3e50-4a72-9097-fe63a27503f1@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2644 bytes --]
On Mon Apr 22, 2024 at 9:02 AM CEST, Krzysztof Kozlowski wrote:
> On 12/04/2024 15:05, Sumit Gupta wrote:
> > MC SID and Broadbast channel register access is restricted for Guest VM.
>
> Broadcast
>
> > Make both the regions as optional for SoC's from Tegra186 onwards.
>
> onward?
>
> > Tegra MC driver will skip access to the restricted registers from Guest
> > if the respective regions are not present in the memory-controller node
> > of Guest DT.
> >
> > Suggested-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> > ---
> > .../nvidia,tegra186-mc.yaml | 95 ++++++++++---------
> > 1 file changed, 49 insertions(+), 46 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> > index 935d63d181d9..e0bd013ecca3 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> > @@ -34,11 +34,11 @@ properties:
> > - nvidia,tegra234-mc
> >
> > reg:
> > - minItems: 6
> > + minItems: 4
> > maxItems: 18
> >
> > reg-names:
> > - minItems: 6
> > + minItems: 4
> > maxItems: 18
> >
> > interrupts:
> > @@ -151,12 +151,13 @@ allOf:
> >
> > reg-names:
> > items:
> > - - const: sid
> > - - const: broadcast
> > - - const: ch0
> > - - const: ch1
> > - - const: ch2
> > - - const: ch3
> > + enum:
> > + - sid
> > + - broadcast
> > + - ch0
> > + - ch1
> > + - ch2
> > + - ch3
>
> I understand why sid and broadcast are becoming optional, but why order
> of the rest is now fully flexible?
The reason why the order of the rest doesn't matter is because we have
both reg and reg-names properties and so the order in which they appear
in the list doesn't matter. The only thing that matters is that the
entries of the reg and reg-names properties match.
> This does not even make sid/broadcast optional, but ch0!
Yeah, this ends up making all entries optional, which isn't what we
want. I don't know of a way to accurately express this in json-schema,
though. Do you?
If not, then maybe we need to resort to something like this and also
mention explicitly in some comment that it is sid and broadcast that are
optional.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-24 16:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 13:05 [Patch v3 0/2] memory: tegra: Skip restricted register access from Guest Sumit Gupta
2024-04-12 13:05 ` [Patch v3 1/2] dt-bindings: make sid and broadcast reg optional Sumit Gupta
2024-04-22 7:02 ` Krzysztof Kozlowski
2024-04-24 16:26 ` Thierry Reding [this message]
2024-04-24 17:04 ` Thierry Reding
2024-04-25 7:52 ` Krzysztof Kozlowski
2024-04-25 9:39 ` Thierry Reding
2024-04-25 9:45 ` Krzysztof Kozlowski
2024-04-25 15:03 ` Thierry Reding
2024-04-25 15:16 ` Krzysztof Kozlowski
2024-04-25 15:51 ` Thierry Reding
2024-04-25 7:51 ` Krzysztof Kozlowski
2024-04-25 7:52 ` Krzysztof Kozlowski
2024-04-12 13:05 ` [Patch v3 2/2] memory: tegra: make sid and broadcast regions optional Sumit Gupta
2024-04-22 7:12 ` Krzysztof Kozlowski
2024-04-22 14:36 ` Sumit Gupta
2024-04-23 14:41 ` Krzysztof Kozlowski
2024-04-23 19:46 ` Sumit Gupta
2024-04-24 4:09 ` Krzysztof Kozlowski
2024-04-24 5:27 ` Sumit Gupta
2024-04-24 5:44 ` Krzysztof Kozlowski
2024-04-24 6:27 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0SHRQVCGJBY.2DPLX9K6VXEYM@gmail.com \
--to=thierry.reding@gmail.com \
--cc=amhetre@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).