From: Sameer Pujar <spujar@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
broonie@kernel.org, linux-sound@vger.kernel.org
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, jonathanh@nvidia.com, mkumard@nvidia.com,
stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Fix DSPK 16-bit playback
Date: Tue, 26 Mar 2024 10:51:18 +0530 [thread overview]
Message-ID: <c778674c-577c-4099-ad44-440c82eb0634@nvidia.com> (raw)
In-Reply-To: <D02VH5KH4A9R.6IOJPPMBF0K5@gmail.com>
On 25-03-2024 19:11, Thierry Reding wrote:
> On Mon Mar 25, 2024 at 11:49 AM CET, Sameer Pujar wrote:
>> DSPK configuration is wrong for 16-bit playback and this happens because
>> the client config is always fixed at 24-bit in hw_params(). Fix this by
>> updating the client config to 16-bit for the respective playback.
>>
>> Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> sound/soc/tegra/tegra186_dspk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c
>> index aa37c4ab0adb..3a152e76122b 100644
>> --- a/sound/soc/tegra/tegra186_dspk.c
>> +++ b/sound/soc/tegra/tegra186_dspk.c
>> @@ -1,8 +1,7 @@
>> // SPDX-License-Identifier: GPL-2.0-only
>> +// SPDX-FileCopyrightText: Copyright (c) 2020-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>> //
>> // tegra186_dspk.c - Tegra186 DSPK driver
>> -//
>> -// Copyright (c) 2020 NVIDIA CORPORATION. All rights reserved.
>>
>> #include <linux/clk.h>
>> #include <linux/device.h>
>> @@ -246,6 +245,7 @@ static int tegra186_dspk_hw_params(struct snd_pcm_substream *substream,
>> switch (params_format(params)) {
>> case SNDRV_PCM_FORMAT_S16_LE:
>> cif_conf.audio_bits = TEGRA_ACIF_BITS_16;
>> + cif_conf.client_bits = TEGRA_ACIF_BITS_16;
> Do we perhaps want to move the common cif_conf.client_bits assignment
> into the S32_LE case now? It doesn't make much sense to have a common
> assignment that's overridden for the S16_LE case and only kept for the
> only other alternative (S32_LE).
Yes, it makes sense to do so. Will send v2. Thanks.
prev parent reply other threads:[~2024-03-26 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 10:49 [PATCH] ASoC: tegra: Fix DSPK 16-bit playback Sameer Pujar
2024-03-25 13:41 ` Thierry Reding
2024-03-26 5:21 ` Sameer Pujar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c778674c-577c-4099-ad44-440c82eb0634@nvidia.com \
--to=spujar@nvidia.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).