From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: Stevie Alvarez <stevie.6strings@gmail.com>,
Ross Zwisler <zwisler@google.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>
Subject: [PATCH 0/6] libtraceeval histogram: Updates
Date: Tue, 8 Aug 2023 23:13:07 -0400 [thread overview]
Message-ID: <20230809031313.1298605-1-rostedt@goodmis.org> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
This patch set is based on top of:
https://lore.kernel.org/all/20230808161204.5704-1-stevie.6strings@gmail.com/
I added a sample program task-eval which is one of the tools that will be
using this library. The first patch adds task-eval but that is still using
the old API (defined in trace-analysis.c).
The next patches modify the new API to fit with the use case of task-eval.
One is to use "pointer" as I'm not sure exactly the usecase of the dynamic
structure.
The cmp and release callbacks are changed to be more generic, and they get
called if they simply exist for a given type. I can imagine wanting a
release function for event the most mundane types (like number_32).
The cmp was also updated to pass in the traceeval descriptor, as I found
that I needed access to it while doing a compare (although, I rewrote the
code a bit where that use case isn't in the tool anymore).
Some fixes were made to the query.
The last patch updates the task-eval to use the new API. It added stubs that
are needed for the display portion. These can be implemented later.
Note, when running the new task-eval, it crashes immediately, so there's
lots of bugs to still fix in the existing histogram code.
Happy programming!
Steven Rostedt (Google) (6):
libtraceeval: Add sample task-eval program
libtraceeval hist: Add pointer and const string types
libtraceeval histogram: Have cmp and release functions be generic
libtraceeval histograms: Add traceeval struct to compare function
libtraceeval histogram: Fix the return value of traceeval_query()
libtraceeval samples: Update task-eval to use the histogram logic
Makefile | 3 +
include/traceeval-hist.h | 38 +-
samples/Makefile | 29 ++
samples/task-eval.c | 948 +++++++++++++++++++++++++++++++++++++++
src/histograms.c | 48 +-
5 files changed, 1026 insertions(+), 40 deletions(-)
create mode 100644 samples/Makefile
create mode 100644 samples/task-eval.c
--
2.40.1
next reply other threads:[~2023-08-09 3:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 3:13 Steven Rostedt [this message]
2023-08-09 3:13 ` [PATCH 1/6] libtraceeval: Add sample task-eval program Steven Rostedt
2023-08-09 3:13 ` [PATCH 2/6] libtraceeval hist: Add pointer and const string types Steven Rostedt
2023-08-09 3:13 ` [PATCH 3/6] libtraceeval histogram: Have cmp and release functions be generic Steven Rostedt
2023-08-09 3:13 ` [PATCH 4/6] libtraceeval histograms: Add traceeval struct to compare function Steven Rostedt
2023-08-09 3:13 ` [PATCH 5/6] libtraceeval histogram: Fix the return value of traceeval_query() Steven Rostedt
2023-08-10 17:47 ` Ross Zwisler
2023-08-11 5:25 ` Steven Rostedt
2023-08-09 3:13 ` [PATCH 6/6] libtraceeval samples: Update task-eval to use the histogram logic Steven Rostedt
2023-08-09 3:19 ` Steven Rostedt
2023-08-10 20:28 ` Ross Zwisler
2023-08-11 5:30 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809031313.1298605-1-rostedt@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).