From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtracefs: Update trace_buffer_meta
Date: Tue, 23 Jan 2024 13:06:32 -0500 [thread overview]
Message-ID: <20240123130632.340a9c06@gandalf.local.home> (raw)
In-Reply-To: <20240123111242.3665230-1-vdonnefort@google.com>
On Tue, 23 Jan 2024 11:12:42 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:
> The current version for struct trace_buffer_meta is taken from a work in
> progress Linux patch series. Update it.
>
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
>
> diff --git a/src/tracefs-mmap.c b/src/tracefs-mmap.c
> index 499233a..d3af453 100644
> --- a/src/tracefs-mmap.c
> +++ b/src/tracefs-mmap.c
> @@ -10,25 +10,24 @@
> #include "tracefs-local.h"
>
> struct trace_buffer_meta {
> - unsigned long entries;
> - unsigned long overrun;
> - unsigned long read;
> + __u32 meta_page_size;
> + __u32 meta_struct_len;
>
> - unsigned long subbufs_touched;
> - unsigned long subbufs_lost;
> - unsigned long subbufs_read;
> + __u32 subbuf_size;
> + __u32 nr_subbufs;
>
> struct {
> - unsigned long lost_events; /* Events lost at the time of the reader swap */
> - __u32 id; /* Reader subbuf ID from 0 to nr_subbufs - 1 */
> - __u32 read; /* Number of bytes read on the reader subbuf */
> + __u64 lost_events;
> + __u32 id;
> + __u32 read;
> } reader;
>
> - __u32 subbuf_size; /* Size of each subbuf including the header */
> - __u32 nr_subbufs; /* Number of subbufs in the ring-buffer */
> + __u64 entries;
> + __u64 overrun;
> + __u64 read;
>
> - __u32 meta_page_size; /* Size of the meta-page */
> - __u32 meta_struct_len; /* Len of this struct */
> + __u64 subbufs_touched;
> + __u64 subbufs_lost;
> };
>
> #define TRACE_MMAP_IOCTL_GET_READER _IO('T', 0x1)
>
> base-commit: 73ac9c192d058712993f9941927c924f2e206168
I'll hold off applying this until we have the kernel side locked down.
As I'm expecting there to be more versions of this patch.
Thanks,
-- Steve
prev parent reply other threads:[~2024-01-23 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 11:12 [PATCH] libtracefs: Update trace_buffer_meta Vincent Donnefort
2024-01-23 18:06 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123130632.340a9c06@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).