From: Pierre Gondois <pierre.gondois@arm.com>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Pierre Gondois <pierre.gondois@arm.com>
Subject: [PATCH v3 0/5] trace-cmd: split: Handle splitting files with multiple instances
Date: Tue, 23 Jan 2024 14:42:10 +0100 [thread overview]
Message-ID: <20240123134215.385415-1-pierre.gondois@arm.com> (raw)
V3:
- Add error handling for strdup() calls.
- Fix bug described at [2]: the split command kept generating
split files forever when the '-r' option was provided.
A new handle was used in each loop, meaning the input file was
being parsed again from the beginning.
- Remove the 2 first patch accepted in v2.
V2:
- Add 'trace-cmd split: Enable support for buffer selection' to
handle instance selection with the 'trace-cmd' split command.
- Rename patches as 'trace-cmd: split' -> 'trace-cmd split'.
- Correctly free allocated memory in different lists.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218357
Splitting trace files having multiple buffer instances discards
side-buffers . I.e., only the main buffer is preserved in the
resulting split trace files. This patch-set intends to fix this.
As a continuation of the bugzilla, support to allow selecting
buffer instances is added to the 'trace-cmd split' command [1].
This support implies adding new '-B/--top' parameters.
Also:
- Fix a side issue preventing to provide start/end timestamps
along with a time-window parameters.
- Update trace-cmd split usage
[1] https://lore.kernel.org/all/20240119122511.440d8f0a@gandalf.local.home/
[2] https://lore.kernel.org/all/20240122192346.5a9035e2@gandalf.local.home/
Pierre Gondois (5):
trace-cmd split: Store instances in local list
trace-cmd split: Add functions to generate temp files
trace-cmd split: Handle splitting files with multiple instances
trace-cmd split: Enable support for buffer selection
trace-cmd split: Update usage
tracecmd/trace-split.c | 550 ++++++++++++++++++++++++++++++++++-------
tracecmd/trace-usage.c | 9 +-
2 files changed, 468 insertions(+), 91 deletions(-)
--
2.25.1
next reply other threads:[~2024-01-23 13:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 13:42 Pierre Gondois [this message]
2024-01-23 13:42 ` [PATCH v3 1/5] trace-cmd split: Store instances in local list Pierre Gondois
2024-01-23 13:42 ` [PATCH v3 2/5] trace-cmd split: Add functions to generate temp files Pierre Gondois
2024-01-23 13:42 ` [PATCH v3 3/5] trace-cmd split: Handle splitting files with multiple instances Pierre Gondois
2024-01-24 22:35 ` Steven Rostedt
2024-01-23 13:42 ` [PATCH v3 4/5] trace-cmd split: Enable support for buffer selection Pierre Gondois
2024-01-24 22:37 ` Steven Rostedt
2024-01-25 15:16 ` Pierre Gondois
2024-01-25 16:28 ` Steven Rostedt
2024-01-25 16:51 ` Steven Rostedt
2024-01-25 17:10 ` Steven Rostedt
2024-01-26 8:54 ` Pierre Gondois
2024-02-02 2:17 ` Steven Rostedt
2024-02-05 13:38 ` Pierre Gondois
2024-02-11 23:35 ` Steven Rostedt
2024-02-12 9:11 ` Pierre Gondois
2024-02-12 21:28 ` Steven Rostedt
2024-01-23 13:42 ` [PATCH v3 5/5] trace-cmd split: Update usage Pierre Gondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123134215.385415-1-pierre.gondois@arm.com \
--to=pierre.gondois@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).