From: Pierre Gondois <pierre.gondois@arm.com>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Pierre Gondois <pierre.gondois@arm.com>
Subject: [PATCH v6 1/2] trace-cmd split: Remove const to (struct handle_list).name
Date: Thu, 22 Feb 2024 17:54:17 +0100 [thread overview]
Message-ID: <20240222165418.2153026-1-pierre.gondois@arm.com> (raw)
(struct handle_list).name was unnecessarily made const in:
commit caa9eda091d6 ("trace-cmd split: Store instances in local list")
Remove it.
Also fix bad indentation.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
Notes:
v6:
- New patch: Remove unnecessary const for (struct handle_list).name
tracecmd/trace-split.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index 2c311b3d..cb6242d8 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -53,9 +53,9 @@ struct cpu_data {
struct handle_list {
struct list_head list;
- const char *name;
+ char *name;
int index;
- struct tracecmd_input *handle;
+ struct tracecmd_input *handle;
/* Identify the top instance in the input trace. */
bool was_top_instance;
@@ -114,7 +114,7 @@ static void free_handles(struct list_head *list)
while (!list_empty(list)) {
item = container_of(list->next, struct handle_list, list);
list_del(&item->list);
- free((char *)item->name);
+ free(item->name);
tracecmd_close(item->handle);
free(item);
}
--
2.25.1
next reply other threads:[~2024-02-22 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:54 Pierre Gondois [this message]
2024-02-22 16:54 ` [PATCH v6 2/2] trace-cmd split: Enable support for buffer selection Pierre Gondois
2024-02-22 17:00 ` [PATCH v6 1/2] trace-cmd split: Remove const to (struct handle_list).name Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222165418.2153026-1-pierre.gondois@arm.com \
--to=pierre.gondois@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).