From: Ian Rogers <irogers@google.com>
To: linux-trace-devel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v1] libtraceevent: Avoid a simple asprintf case
Date: Wed, 8 May 2024 22:13:17 -0700 [thread overview]
Message-ID: <20240509051317.1913001-1-irogers@google.com> (raw)
Avoid an asprintf for the single character TEP_EVENT_NEWLINE and
TEP_EVENT_DELIM case.
Signed-off-by: Ian Rogers <irogers@google.com>
---
src/event-parse.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/event-parse.c b/src/event-parse.c
index b6ae67e..16fdb46 100644
--- a/src/event-parse.c
+++ b/src/event-parse.c
@@ -1232,9 +1232,11 @@ static enum tep_event_type __read_token(struct tep_handle *tep, char **tok)
switch (type) {
case TEP_EVENT_NEWLINE:
case TEP_EVENT_DELIM:
- if (asprintf(tok, "%c", ch) < 0)
+ *tok = malloc(2);
+ if (!*tok)
return TEP_EVENT_ERROR;
-
+ (*tok)[0] = ch;
+ (*tok)[1] = '\0';
return type;
case TEP_EVENT_OP:
--
2.45.0.rc1.225.g2a3ae87e7f-goog
next reply other threads:[~2024-05-09 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 5:13 Ian Rogers [this message]
2024-05-16 22:02 ` [PATCH v1] libtraceevent: Avoid a simple asprintf case Steven Rostedt
2024-05-16 22:09 ` Ian Rogers
2024-05-16 23:51 ` Steven Rostedt
2024-05-28 15:51 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509051317.1913001-1-irogers@google.com \
--to=irogers@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).