From: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
To: Dave Martin <Dave.Martin@arm.com>, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"H. Peter Anvin" <hpa@zytor.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Andreas Larsson <andreas@gaisler.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Borislav Petkov <bp@alien8.de>, Brian Cain <bcain@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Chris Zankel <chris@zankel.net>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guo Ren <guoren@kernel.org>, Heiko Carstens <hca@linux.ibm.com>,
Helge Deller <deller@gmx.de>, Huacai Chen <chenhuacai@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Johannes Berg <johannes@sipsolutions.net>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Jonas Bonn <jonas@southpole.se>, Kees Cook <kees@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rich Felker <dalias@libc.org>,
Richard Weinberger <richard@nod.at>,
Russell King <linux@armlinux.org.uk>,
Stafford Horne <shorne@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@kernel.org>, WANG Xuerui <kernel@xen0n.name>,
Will Deacon <will@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, sparclinux@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH 00/23] binfmt_elf,arch/*: Use elf.h for coredump note names
Date: Wed, 9 Jul 2025 14:05:53 +0900 [thread overview]
Message-ID: <36c0213c-6b14-4ad2-969e-3d8e356bb680@rsg.ci.i.u-tokyo.ac.jp> (raw)
In-Reply-To: <20250701135616.29630-1-Dave.Martin@arm.com>
On 2025/07/01 22:55, Dave Martin wrote:
> This series aims to clean up an aspect of coredump generation:
>
> ELF coredumps contain a set of notes describing the state of machine
> registers and other information about the dumped process.
>
> Notes are identified by a numeric identifier n_type and a "name"
> string, although this terminology is somewhat misleading. Officially,
> the "name" of a note is really an "originator" or namespace identifier
> that indicates how to interpret n_type [1], although in practice it is
> often used more loosely.
>
> Either way, each kind of note needs _both_ a specific "name" string and
> a specific n_type to identify it robustly.
>
> To centralise this knowledge in one place and avoid the need for ad-hoc
> code to guess the correct name for a given note, commit 7da8e4ad4df0
> ("elf: Define note name macros") [2] added an explicit NN_<foo> #define
> in elf.h to give the name corresponding to each named note type
> NT_<foo>.
>
> Now that the note name for each note is specified explicitly, the
> remaining guesswork for determining the note name for common and
> arch-specific regsets in ELF core dumps can be eliminated.
>
> This series aims to do just that:
>
> * Patch 2 adds a user_regset field to specify the note name, and a
> helper macro to populate it correctly alongside the note type.
>
> * Patch 3 ports away the ad-hoc note names in the common coredump
> code.
>
> * Patches 4-22 make the arch-specific changes. (This is pretty
> mechanical for most arches.)
>
> * The final patch adds a WARN() when no note name is specified,
> and simplifies the fallback guess. This should only be applied
> when all arches have ported across.
>
> See the individual patches for details.
>
>
> Testing:
>
> * x86, arm64: Booted in a VM and triggered a core dump with no WARN(),
> and verified that the dumped notes are the same.
>
> * arm: Build-tested only (for now).
>
> * Other arches: not tested yet
>
> Any help with testing is appreciated. If the following generates the
> same notes (as dumped by readelf -n core) and doesn't trigger a WARN,
> then we are probably good.
>
> $ sleep 60 &
> $ kill -QUIT $!
>
> (Register content might differ between runs, but it should be safe to
> ignore that -- this series only deals with the note names and types.)
>
> Cheers
> ---Dave
>
>
> [1] System V Application Binary Interface, Edition 4.1,
> Section 5 (Program Loading and Dynamic Linking) -> "Note Section"
>
> https://refspecs.linuxfoundation.org/elf/gabi41.pdf
>
> [2] elf: Define note name macros
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/elf.h?id=7da8e4ad4df0dd12f37357af62ce1b63e75ae2e6
>
>
> Dave Martin (23):
> regset: Fix kerneldoc for struct regset_get() in user_regset
> regset: Add explicit core note name in struct user_regset
> binfmt_elf: Dump non-arch notes with strictly matching name and type
> ARC: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> ARM: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> arm64: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> csky: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> hexagon: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> LoongArch: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> m68k: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> MIPS: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> nios2: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> openrisc: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> parisc: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> powerpc/ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> riscv: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> s390/ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> sh: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> sparc: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> x86/ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> um: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note names
> xtensa: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset note
> names
> binfmt_elf: Warn on missing or suspicious regset note names
>
> arch/arc/kernel/ptrace.c | 4 +-
> arch/arm/kernel/ptrace.c | 6 +-
> arch/arm64/kernel/ptrace.c | 52 ++++++++---------
> arch/csky/kernel/ptrace.c | 4 +-
> arch/hexagon/kernel/ptrace.c | 2 +-
> arch/loongarch/kernel/ptrace.c | 16 ++---
> arch/m68k/kernel/ptrace.c | 4 +-
> arch/mips/kernel/ptrace.c | 20 +++----
> arch/nios2/kernel/ptrace.c | 2 +-
> arch/openrisc/kernel/ptrace.c | 4 +-
> arch/parisc/kernel/ptrace.c | 8 +--
> arch/powerpc/kernel/ptrace/ptrace-view.c | 74 ++++++++++++------------
> arch/riscv/kernel/ptrace.c | 12 ++--
> arch/s390/kernel/ptrace.c | 42 +++++++-------
> arch/sh/kernel/ptrace_32.c | 4 +-
> arch/sparc/kernel/ptrace_32.c | 4 +-
> arch/sparc/kernel/ptrace_64.c | 8 +--
> arch/x86/kernel/ptrace.c | 22 +++----
> arch/x86/um/ptrace.c | 10 ++--
> arch/xtensa/kernel/ptrace.c | 4 +-
> fs/binfmt_elf.c | 36 +++++++-----
> fs/binfmt_elf_fdpic.c | 17 +++---
> include/linux/regset.h | 12 +++-
> 23 files changed, 194 insertions(+), 173 deletions(-)
>
>
> base-commit: 86731a2a651e58953fc949573895f2fa6d456841
For the whole series:
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2025-07-09 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 13:55 [PATCH 00/23] binfmt_elf,arch/*: Use elf.h for coredump note names Dave Martin
2025-07-01 13:56 ` [PATCH 21/23] um: ptrace: Use USER_REGSET_NOTE_TYPE() to specify regset " Dave Martin
2025-07-04 11:58 ` Johannes Berg
2025-07-04 16:46 ` Dave Martin
2025-07-09 5:05 ` Akihiko Odaki [this message]
2025-07-15 5:37 ` [PATCH 00/23] binfmt_elf,arch/*: Use elf.h for coredump " Kees Cook
2025-07-15 10:32 ` Dave Martin
2025-08-10 21:12 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c0213c-6b14-4ad2-969e-3d8e356bb680@rsg.ci.i.u-tokyo.ac.jp \
--to=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=Dave.Martin@arm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=alex@ghiti.fr \
--cc=andreas@gaisler.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=bcain@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jonas@southpole.se \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).