linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-um@lists.infradead.org, Linux KVM <kvm@vger.kernel.org>,
	Nipun Gupta <nipun.gupta@amd.com>,
	Nikhil Agarwal <nikhil.agarwal@amd.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c)
Date: Wed, 16 Jul 2025 16:07:38 -0700	[thread overview]
Message-ID: <4a6fd102-f8e0-42f3-b789-6e3340897032@infradead.org> (raw)
In-Reply-To: <20250716212558.4dd0502b@canb.auug.org.au>



On 7/16/25 4:25 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20250715:
> 

on ARCH=um SUBARCH=x86_64:

../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_enable’:
../drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function ‘msi_domain_alloc_irqs’; did you mean ‘msi_domain_get_virq’? [-Wimplicit-function-declaration]
   41 |         ret = msi_domain_alloc_irqs(dev, MSI_DEFAULT_DOMAIN, nvec);
      |               ^~~~~~~~~~~~~~~~~~~~~
      |               msi_domain_get_virq
../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_disable’:
../drivers/vfio/cdx/intr.c:135:9: error: implicit declaration of function ‘msi_domain_free_irqs_all’ [-Wimplicit-function-declaration]
  135 |         msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~


Those missing functions are provided by CONFIG_GENERIC_MSI_IRQ
(which is not set).

Should VFIO_CDX select GENERIC_MSI_IRQ or just not build on ARCH=um?


-- 
~Randy



       reply	other threads:[~2025-07-16 23:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250716212558.4dd0502b@canb.auug.org.au>
2025-07-16 23:07 ` Randy Dunlap [this message]
2025-07-17  6:52   ` linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c) Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a6fd102-f8e0-42f3-b789-6e3340897032@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).