From: "Tiwei Bie" <tiwei.btw@antgroup.com>
To: Ivan Orlov <ivan.orlov0322@gmail.com>,
richard@nod.at, anton.ivanov@cambridgegreys.com,
johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: tlb: Remove unused flush_tlb_mm_range function
Date: Mon, 15 Apr 2024 10:18:31 +0800 [thread overview]
Message-ID: <54e7d96b-20b7-4f9b-af20-f602438b78fc@antgroup.com> (raw)
In-Reply-To: <20240414211934.393303-1-ivan.orlov0322@gmail.com>
On 4/15/24 5:19 AM, Ivan Orlov wrote:
> GCC 11.4.0 produces the following warning when compiling the kernel for
> UML architecture (with UML defconfig):
>
> arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
> 579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,)
>
> This function is not used anywhere. It is not exported with
> `EXPORT_SYMBOL` either, and therefore it is not usable for dynamically
> loaded modules. Remove this function.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> ---
> arch/um/kernel/tlb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c
> index 7d050ab0f78a..70b5e47e9761 100644
> --- a/arch/um/kernel/tlb.c
> +++ b/arch/um/kernel/tlb.c
> @@ -576,12 +576,6 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
> }
> EXPORT_SYMBOL(flush_tlb_range);
>
> -void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
> - unsigned long end)
> -{
> - fix_range(mm, start, end, 0);
> -}
> -
> void flush_tlb_mm(struct mm_struct *mm)
> {
> struct vm_area_struct *vma;
Thanks for the patch. I also posted a fix for this earlier (but not merged yet):
https://lore.kernel.org/linux-um/20240306101925.1088870-4-tiwei.btw@antgroup.com/
Regards,
Tiwei
prev parent reply other threads:[~2024-04-15 2:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 21:19 [PATCH] um: tlb: Remove unused flush_tlb_mm_range function Ivan Orlov
2024-04-15 2:18 ` Tiwei Bie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54e7d96b-20b7-4f9b-af20-f602438b78fc@antgroup.com \
--to=tiwei.btw@antgroup.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ivan.orlov0322@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).