From: Johannes Berg <johannes@sipsolutions.net>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Richard Weinberger <richard@nod.at>,
linux-um@lists.infradead.org
Subject: Re: [PATCH] um: let 'make clean' properly clean underlying SUBARCH as well
Date: Wed, 07 May 2025 18:13:59 +0200 [thread overview]
Message-ID: <7a92e3eb5947837d16f8b7f1adec9ffc4fda397d.camel@sipsolutions.net> (raw)
In-Reply-To: <20250507074936.486648-1-masahiroy@kernel.org>
On Wed, 2025-05-07 at 16:49 +0900, Masahiro Yamada wrote:
> Building the kernel with O= is affected by stale in-tree build artifacts.
>
> So, if the source tree is not clean, Kbuild displays the following:
>
> $ make ARCH=um O=build defconfig
> make[1]: Entering directory '/.../linux/build'
> ***
> *** The source tree is not clean, please run 'make ARCH=um mrproper'
> *** in /.../linux
> ***
> make[2]: *** [/.../linux/Makefile:673: outputmakefile] Error 1
> make[1]: *** [/.../linux/Makefile:248: __sub-make] Error 2
> make[1]: Leaving directory '/.../linux/build'
> make: *** [Makefile:248: __sub-make] Error 2
>
> Usually, running 'make mrproper' is sufficient for cleaning the source
> tree for out-of-tree builds.
>
> However, building UML generates build artifacts not only in arch/um/,
> but also in the SUBARCH directory (i.e., arch/x86/). If in-tree stale
> files remain under arch/x86/, Kbuild will reuse them instead of creating
> new ones under the specified build directory.
>
> This commit makes 'make ARCH=um clean' recurse into the SUBARCH directory.
Do you want to take that through your tree? I'm not sure we'd get it
into 6.15 at this point via uml, if you have some other material feel
free to take it:
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Otherwise we can take it via uml tree for 6.16 too, let us know.
johannes
next prev parent reply other threads:[~2025-05-07 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:49 [PATCH] um: let 'make clean' properly clean underlying SUBARCH as well Masahiro Yamada
2025-05-07 16:13 ` Johannes Berg [this message]
2025-05-07 21:38 ` Shuah Khan
2025-05-07 23:49 ` Masahiro Yamada
2025-05-08 22:14 ` Shuah Khan
2025-05-08 23:43 ` Masahiro Yamada
2025-05-08 5:29 ` Johannes Berg
2025-05-08 7:38 ` Geert Uytterhoeven
2025-05-08 8:14 ` Masahiro Yamada
2025-05-08 8:17 ` Geert Uytterhoeven
2025-05-08 6:12 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a92e3eb5947837d16f8b7f1adec9ffc4fda397d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=richard@nod.at \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).