From: Jani Nikula <jani.nikula@intel.com>
To: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org
Cc: intel-xe@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: -Wmissing-prototypes warnings in user-mode linux
Date: Tue, 05 Mar 2024 12:34:39 +0200 [thread overview]
Message-ID: <87jzmh2chs.fsf@intel.com> (raw)
We're seeing a lot of -Wmissing-prototypes warnings when building
user-mode Linux. For example, our CI hits things like [1], and it's just
extra noise in the build.
I started adding some prototypes, but I lost my way around the arch/
subdirectory a bit. I'm not always quite sure what should or could be
included where, or whether a new header should be added instead, etc.,
so it wasn't going as quickly as I'd hoped.
Do you perhaps already have plans or, better yet, patches to address
this? Feels like it should be fairly quick for someone familiar with the
arch/um codebase.
BR,
Jani.
[1] https://lore.kernel.org/r/170963008487.503981.6735326012843985651@8e613ede5ea5
--
Jani Nikula, Intel
next reply other threads:[~2024-03-05 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 10:34 Jani Nikula [this message]
2024-03-05 10:35 ` -Wmissing-prototypes warnings in user-mode linux Johannes Berg
2024-03-05 10:49 ` Jani Nikula
2024-03-05 11:17 ` Johannes Berg
2024-03-05 11:18 ` Tiwei Bie
2024-03-05 13:45 ` Jani Nikula
2024-03-05 14:26 ` Tiwei Bie
2024-04-22 20:35 ` Richard Weinberger
2024-04-23 4:59 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzmh2chs.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=johannes@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).