From: Masahiro Yamada <masahiroy@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: anton ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>, bp <bp@alien8.de>,
dave hansen <dave.hansen@linux.intel.com>, hpa <hpa@zytor.com>,
mingo <mingo@redhat.com>, tglx <tglx@linutronix.de>,
x86 <x86@kernel.org>
Subject: Re: [PATCH v2 1/2] UML: hard-code the result of 'uname -s'
Date: Sun, 20 Aug 2023 08:03:54 +0900 [thread overview]
Message-ID: <CAK7LNATX4uekv=W9Rsvwxc-3fuNJvUZsAO49qV_TCzsWZu76XA@mail.gmail.com> (raw)
In-Reply-To: <707999896.6490583.1692479291135.JavaMail.zimbra@nod.at>
On Sun, Aug 20, 2023 at 6:15 AM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "masahiroy" <masahiroy@kernel.org>
> > We rely on 'uname -s' returning 'Linux' because there are os-Linux/
> > directories, but no other os-*/.
> >
> > Supporting a non-Linux host is unlikely to happen.
> >
> > Let's hard-code 'Linux'.
>
> While I agree that a non-Linux version is unlikely I'd like to
> know why we can't keep the uname -s check?
> I guess to avoid unnecessary command execution?
Just because 'uname -s' is meaningless.
Just build 'Linux' ones irrespective of the host platform.
If it works, it works.
If not, it does not work.
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2023-08-19 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 17:18 [PATCH v2 1/2] UML: hard-code the result of 'uname -s' Masahiro Yamada
2023-07-21 17:18 ` [PATCH v2 2/2] UML: use obj-y to descend into arch/um/*/ Masahiro Yamada
2023-07-24 6:53 ` Jiri Slaby
2023-08-08 18:21 ` Nick Desaulniers
2023-08-19 21:08 ` [PATCH v2 1/2] UML: hard-code the result of 'uname -s' Richard Weinberger
2023-08-19 23:03 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATX4uekv=W9Rsvwxc-3fuNJvUZsAO49qV_TCzsWZu76XA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).