From: Masahiro Yamada <masahiroy@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Richard Weinberger <richard@nod.at>,
linux-um@lists.infradead.org, David Gow <davidgow@google.com>
Subject: Re: [PATCH] um: let 'make clean' properly clean underlying SUBARCH as well
Date: Thu, 8 May 2025 17:14:15 +0900 [thread overview]
Message-ID: <CAK7LNAT_m+R3Keyys2NpmQWRmZzHNv9FM_ALv=vn_WMzTSWhyw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdUwE7btR+ebG8-gvPb8GPnxUGPWw3yKR4qM4Uc_mYcHhg@mail.gmail.com>
On Thu, May 8, 2025 at 4:38 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Johannes,
>
> On Thu, 8 May 2025 at 07:29, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Wed, 2025-05-07 at 15:38 -0600, Shuah Khan wrote:
> > > My workflow:
> > >
> > > - Build kernel on x86_64 with CONFIG_AMD_MEM_ENCRYPT enabled
> > >
> > > - Check for arch/x86/realmode/rm/pasyms.h
> > > ls arch/x86/realmode/rm/pasyms.h
> > > arch/x86/realmode/rm/pasyms.h
> > >
> > > - make ARCH=um O=/linux/build
> > >
> > > This patch cleans the source tree, but doesn't remove
> > > arch/x86/realmode/rm/pasyms.h
> > >
> > > - ls arch/x86/realmode/rm/pasyms.h
> > > arch/x86/realmode/rm/pasyms.h
> >
> > Is that even _expected_ to work? If you have x86 built first, I'd almost
> > expect you to have to do "make ARCH=x86 mrproper" before building
> > another ARCH. I don't see how ARCH=um would know how to do a full clean
> > up of ARCH=x86, unless this is somehow arch-independent?
> >
> > Or maybe that's not an issue with other architectures because UML is
> > special in that it uses parts of x86?
>
> Probably.
> I only use my linux-next source tree for fixing reported build issues on
> various architectures, and I never use make clean/mrproper. Works fine.
>
> > Though I guess the patch here should make it do that, more or less, but
> > it can't, likely because you're also switching from in-tree build to O=
> > build?
>
> Yeah, mixing in-tree and out-of-tree builds causes issues.
> Never build in-tree in a source tree you use with O= (except for
> e.g. "make tags").
>
I argue this.
You can start out-of-tree builds after running 'make mrproper'
for the architecture you want to build the kernel for.
Hence, Kbuild suggests to do so when it determines
the source tree is not clean enough.
Unfortunately, "make mrproper ARCH=um" did not clean the tree
deeply enough. Hence, this patch.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2025-05-08 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:49 [PATCH] um: let 'make clean' properly clean underlying SUBARCH as well Masahiro Yamada
2025-05-07 16:13 ` Johannes Berg
2025-05-07 21:38 ` Shuah Khan
2025-05-07 23:49 ` Masahiro Yamada
2025-05-08 22:14 ` Shuah Khan
2025-05-08 23:43 ` Masahiro Yamada
2025-05-08 5:29 ` Johannes Berg
2025-05-08 7:38 ` Geert Uytterhoeven
2025-05-08 8:14 ` Masahiro Yamada [this message]
2025-05-08 8:17 ` Geert Uytterhoeven
2025-05-08 6:12 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT_m+R3Keyys2NpmQWRmZzHNv9FM_ALv=vn_WMzTSWhyw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).