From: Markus Elfring <Markus.Elfring@web.de>
To: Minjie Du <duminjie@vivo.com>,
linux-um@lists.infradead.org, kernel-janitors@vger.kernel.org,
bpf@vger.kernel.org
Cc: opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Richard Weinberger <richard@nod.at>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v3] um: vector: Replace undo_user_init in old code with out_free_netdev
Date: Tue, 4 Jul 2023 10:10:38 +0200 [thread overview]
Message-ID: <a30aec3c-fb81-4e5d-c131-e59de87a3aed@web.de> (raw)
In-Reply-To: <20230704042942.3984-1-duminjie@vivo.com>
> Thanks for your response and suggestions,
> I made some mistakes. This is a resubmitted patch.
You present a need for further improvements.
> I got some errors with my local repository,
> so I lost the commit SHA-1 ID.
I wonder about such information here.
> Fixes: ("drivers: use free_netdev before return in vector_eth_configure()")
Please provide a missing detail.
> Please check this link to see previous replies.
> Link: https://lore.kernel.org/all/8854675f-99e7-314e-c986-8dc954ee4a27@web.de/
Would a subject like “[PATCH v4] um: vector: Fix exception handling in vector_eth_configure()”
be more appropriate?
> This patch make out_free_netdev replace undo_user_init,
> fix etherdev leak in error return path.
The resource cleanup was incomplete in the implementation of the function “vector_eth_configure”.
Thus replace the jump target “out_undo_user_init” by “out_free_netdev”.
…
> ---
> arch/um/drivers/vector_kern.c | 4 +---
…
I would appreciate further version descriptions here.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n698
Regards,
Markus
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2023-07-04 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 4:29 [PATCH v3] um: vector: Replace undo_user_init in old code with out_free_netdev Minjie Du
2023-07-04 8:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30aec3c-fb81-4e5d-c131-e59de87a3aed@web.de \
--to=markus.elfring@web.de \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bpf@vger.kernel.org \
--cc=duminjie@vivo.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=opensource.kernel@vivo.com \
--cc=richard@nod.at \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).