From: Guenter Roeck <linux@roeck-us.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] usb: ohci: Prevent missed ohci interrupts
Date: Wed, 24 Apr 2024 11:21:54 -0700 [thread overview]
Message-ID: <1f94db3e-2ebd-4659-9f88-8591172c3cf0@roeck-us.net> (raw)
In-Reply-To: <57511487-e622-476d-adb2-5dfc725032d4@rowland.harvard.edu>
On 4/24/24 11:15, Alan Stern wrote:
> On Wed, Apr 24, 2024 at 10:02:50AM -0700, Guenter Roeck wrote:
>> Testing ohci functionality with qemu's pci-ohci emulation often results
>> in ohci interface stalls, resulting in hung task timeouts.
>>
>> The problem is caused by lost interrupts between the emulation and the
>> Linux kernel code. Additional interrupts raised while the ohci interrupt
>> handler in Linux is running and before the handler clears the interrupt
>> status are not handled. The fix for a similar problem in ehci suggests
>> that the problem is likely caused by edge-triggered MSI interrupts. See
>> commit 0b60557230ad ("usb: ehci: Prevent missed ehci interrupts with
>> edge-triggered MSI") for details.
>>
>> Ensure that the ohci interrupt code handles all pending interrupts before
>> returning to solve the problem.
>>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Fixes: 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> drivers/usb/host/ohci-hcd.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
>> index 4f9982ecfb58..4d764eb6c1e5 100644
>> --- a/drivers/usb/host/ohci-hcd.c
>> +++ b/drivers/usb/host/ohci-hcd.c
>> @@ -888,6 +888,7 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
>> /* Check for an all 1's result which is a typical consequence
>> * of dead, unclocked, or unplugged (CardBus...) devices
>> */
>> +again:
>> if (ints == ~(u32)0) {
>> ohci->rh_state = OHCI_RH_HALTED;
>> ohci_dbg (ohci, "device removed!\n");
>> @@ -982,6 +983,11 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
>> }
>> spin_unlock(&ohci->lock);
>>
>> + /* repeat until all enabled interrupts are handled */
>> + ints = ohci_readl(ohci, ®s->intrstatus);
>> + if (ints & ohci_readl(ohci, ®s->intrenable))
>> + goto again;
>
> If we take the repeat, we don't want to return IRQ_NOTMINE by accident. To
> prevent this, we should check that ohci->rh_state != OHCI_RH_HALTED before
> re-reading ints and jumping back.
>
> (If rh_state _is_ OHCI_RH_HALTED, it means the device is supposedly stopped
> and disabled for generating further interrupt requests, so we shouldn't
> need to worry about any outstanding intrstatus bits still set.)
>
Makes sense. I'll send v2.
Thanks,
Guenter
prev parent reply other threads:[~2024-04-24 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 17:02 [PATCH] usb: ohci: Prevent missed ohci interrupts Guenter Roeck
2024-04-24 18:15 ` Alan Stern
2024-04-24 18:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f94db3e-2ebd-4659-9f88-8591172c3cf0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).