From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: gregkh@lnuxfoundation.org, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org
Subject: Re: [PATCHv2] usb: usb_parse_endpoint ignore reserved bits
Date: Thu, 18 Apr 2024 15:00:43 +0200 [thread overview]
Message-ID: <2024041812-slogan-thirteen-2b75@gregkh> (raw)
In-Reply-To: <20240418110249.10643-1-oneukum@suse.com>
On Thu, Apr 18, 2024 at 01:02:21PM +0200, Oliver Neukum wrote:
> Reading bEndpointAddress the spec tells is
> that
>
> b7 is direction, which must be ignored
> b6:4 are reserved which are to be set to zero
> b3:0 are the endpoint address
>
> In order to be backwards compatible with possible
> future versions of USB we have to be ready with
> devices using those bits. That means that we
> also have to ignore them like we do with the direction
> bit.
> In consequence the only illegal address you can
> encoding in four bits is endpoint zero, for which
> no descriptor must exist. Hence the check for exceeding
> the upper limit on endpoint addresses is removed.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
>
> V2: Improved commit log
Nit, "V2" goes below the --- line.
> ---
> drivers/usb/core/config.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 8fd4208d17db..43c5ed256e6e 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -285,11 +285,11 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
> goto skip_to_next_endpoint_or_interface_descriptor;
> }
>
> - i = d->bEndpointAddress & ~USB_ENDPOINT_DIR_MASK;
> - if (i >= 16 || i == 0) {
> + i = d->bEndpointAddress & 0x0f;
Using a #define here instead of 0x0f might be good, right?
thanks,
greg k-h
next prev parent reply other threads:[~2024-04-18 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 11:02 [PATCHv2] usb: usb_parse_endpoint ignore reserved bits Oliver Neukum
2024-04-18 13:00 ` Greg KH [this message]
2024-04-18 15:51 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041812-slogan-thirteen-2b75@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gregkh@lnuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).