From: kernel test robot <lkp@intel.com>
To: Mans Rullgard <mans@mansr.com>, Johan Hovold <johan@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: use tty_port_register_device_serdev
Date: Fri, 3 May 2024 07:04:22 +0800 [thread overview]
Message-ID: <202405030657.vgUKnyOZ-lkp@intel.com> (raw)
In-Reply-To: <20240502100728.7914-1-mans@mansr.com>
Hi Mans,
kernel test robot noticed the following build errors:
[auto build test ERROR on johan-usb-serial/usb-next]
[also build test ERROR on johan-usb-serial/usb-linus usb/usb-testing usb/usb-next usb/usb-linus tty/tty-testing tty/tty-next tty/tty-linus linus/master v6.9-rc6 next-20240502]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mans-Rullgard/USB-serial-use-tty_port_register_device_serdev/20240502-180923
base: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next
patch link: https://lore.kernel.org/r/20240502100728.7914-1-mans%40mansr.com
patch subject: [PATCH] USB: serial: use tty_port_register_device_serdev
config: s390-randconfig-r081-20240503 (https://download.01.org/0day-ci/archive/20240503/202405030657.vgUKnyOZ-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405030657.vgUKnyOZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405030657.vgUKnyOZ-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/usb/serial/bus.c: In function 'usb_serial_device_probe':
>> drivers/usb/serial/bus.c:53:19: error: too few arguments to function 'tty_port_register_device_serdev'
53 | tty_dev = tty_port_register_device_serdev(&port->port,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/tty.h:11,
from drivers/usb/serial/bus.c:10:
include/linux/tty_port.h:150:16: note: declared here
150 | struct device *tty_port_register_device_serdev(struct tty_port *port,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/tty_port_register_device_serdev +53 drivers/usb/serial/bus.c
31
32 static int usb_serial_device_probe(struct device *dev)
33 {
34 struct usb_serial_port *port = to_usb_serial_port(dev);
35 struct usb_serial_driver *driver;
36 struct device *tty_dev;
37 int retval = 0;
38 int minor;
39
40 /* make sure suspend/resume doesn't race against port_probe */
41 retval = usb_autopm_get_interface(port->serial->interface);
42 if (retval)
43 return retval;
44
45 driver = port->serial->type;
46 if (driver->port_probe) {
47 retval = driver->port_probe(port);
48 if (retval)
49 goto err_autopm_put;
50 }
51
52 minor = port->minor;
> 53 tty_dev = tty_port_register_device_serdev(&port->port,
54 usb_serial_tty_driver,
55 minor, dev);
56 if (IS_ERR(tty_dev)) {
57 retval = PTR_ERR(tty_dev);
58 goto err_port_remove;
59 }
60
61 usb_autopm_put_interface(port->serial->interface);
62
63 dev_info(&port->serial->dev->dev,
64 "%s converter now attached to ttyUSB%d\n",
65 driver->description, minor);
66
67 return 0;
68
69 err_port_remove:
70 if (driver->port_remove)
71 driver->port_remove(port);
72 err_autopm_put:
73 usb_autopm_put_interface(port->serial->interface);
74
75 return retval;
76 }
77
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-05-02 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 10:07 [PATCH] USB: serial: use tty_port_register_device_serdev Mans Rullgard
2024-05-02 10:18 ` Johan Hovold
2024-05-02 10:45 ` Måns Rullgård
2024-05-02 10:54 ` Greg Kroah-Hartman
2024-05-02 13:24 ` Måns Rullgård
2024-05-02 13:57 ` Greg Kroah-Hartman
2024-05-02 14:32 ` Måns Rullgård
2024-05-02 23:04 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405030657.vgUKnyOZ-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).