From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"quic_ppratap@quicinc.com" <quic_ppratap@quicinc.com>,
"quic_jackp@quicinc.com" <quic_jackp@quicinc.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] usb: dwc3: core: Fix unused variable warning in core driver
Date: Sat, 11 May 2024 08:40:55 +0100 [thread overview]
Message-ID: <2024051147-prance-importer-8eed@gregkh> (raw)
In-Reply-To: <0f056ece-6d38-428e-bf18-edb053c90ca7@quicinc.com>
On Sat, May 11, 2024 at 12:56:29AM +0530, Krishna Kurapati PSSNV wrote:
>
>
> On 5/10/2024 2:58 PM, Greg Kroah-Hartman wrote:
> > On Wed, May 08, 2024 at 11:08:43PM +0000, Thinh Nguyen wrote:
> > > On Mon, May 06, 2024, Krishna Kurapati wrote:
> > > > While fixing a merge conflict in linux-next, hw_mode variable
> > > > was left unused. Remove the unused variable in hs_phy_setup call.
> > > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/202405030439.AH8NR0Mg-lkp@intel.com/__;!!A4F2R9G_pg!aXN14tvkvwnNZ9N8-EDi-Seef9jgZBKlkZRYasINRgTOU2ijWbTvFIxkZIXOThGQQHmXc0FjiJPFI1cgdCOyAafAxB-70Q$
> > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> > > > ---
> > > > Changes in v2:
> > > > Added reported by and closes tags.
> > > >
> > > > drivers/usb/dwc3/core.c | 3 ---
> > > > 1 file changed, 3 deletions(-)
> > > >
> > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > > > index 8b6f7769fcd5..7f176ba25354 100644
> > > > --- a/drivers/usb/dwc3/core.c
> > > > +++ b/drivers/usb/dwc3/core.c
> > > > @@ -676,11 +676,8 @@ static int dwc3_ss_phy_setup(struct dwc3 *dwc, int index)
> > > > static int dwc3_hs_phy_setup(struct dwc3 *dwc, int index)
> > > > {
> > > > - unsigned int hw_mode;
> > > > u32 reg;
> > > > - hw_mode = DWC3_GHWPARAMS0_MODE(dwc->hwparams.hwparams0);
> > > > -
> > > > reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(index));
> > > > /* Select the HS PHY interface */
> > > > --
> > > > 2.34.1
> > > >
> > >
> > > Looks like my response reporting the merge issue to Stephen fell through
> > > the cracks.
> > >
> > > Thanks for the patch.
> > >
> > > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> >
> > I think I already fixed this up when I did the merge a few hours ago, if
> > not, please let me know.
> >
>
> Hi Greg,
>
> I just checked usb-next and linux-next. The unused variable is still there.
> Can you pick this change up.
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2024-05-11 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 7:49 [PATCH v2] usb: dwc3: core: Fix unused variable warning in core driver Krishna Kurapati
2024-05-08 23:08 ` Thinh Nguyen
2024-05-10 9:28 ` Greg Kroah-Hartman
2024-05-10 19:26 ` Krishna Kurapati PSSNV
2024-05-11 1:07 ` Thinh Nguyen
2024-05-11 7:40 ` Greg Kroah-Hartman
2024-05-11 7:40 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024051147-prance-importer-8eed@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).