From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: uhci: convert to dt schema
Date: Sun, 21 Apr 2024 20:26:58 +0200 [thread overview]
Message-ID: <83db906d-3247-41b3-8c29-813d55748da0@kernel.org> (raw)
In-Reply-To: <20240420142108.76984-1-sheharyaar48@gmail.com>
On 20/04/2024 16:21, Mohammad Shehar Yaar Tausif wrote:
> Convert USB UHCI bindings to DT schema
>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> new file mode 100644
> index 000000000000..511c3ecd8d53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/usb-uhci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic Platform UHCI Controller
> +
> +allOf:
> + - $ref: usb-hcd.yaml#
> +
> +maintainers:
> + - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> +
> +properties:
> + compatible:
> + const: generic-uhci
You missed deprecated compatible. Also missed Aspeed compatibles.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
Please confirm that you tested DTS.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + usb@d8007b00 {
> + compatible = "generic-uhci";
Use 4 spaces for example indentation.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-21 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 14:21 [PATCH] dt-bindings: usb: uhci: convert to dt schema Mohammad Shehar Yaar Tausif
2024-04-21 18:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83db906d-3247-41b3-8c29-813d55748da0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheharyaar48@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).