From: Badhri Jagan Sridharan <badhri@google.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: gregkh@linuxfoundation.org, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, kyletso@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
rdbabiera@google.com, amitsd@google.com, stable@vger.kernel.org,
frank.wang@rock-chips.com, broonie@kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Check for port partner validity before consuming it
Date: Sat, 27 Apr 2024 13:30:51 -0700 [thread overview]
Message-ID: <CAPTae5+gkdBmjO7Gm-tZ+5CKXAzmGOsNzEJ_ZQVb0rsaLsCU7A@mail.gmail.com> (raw)
In-Reply-To: <ktl5xjnb7njuoyobnekivyjw6uf6ozn7shd2wubl5styzmmoc6@buzgfwr5wive>
On Sat, Apr 27, 2024 at 12:23 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Sat, Apr 27, 2024 at 05:50:10PM +0000, Badhri Jagan Sridharan wrote:
> > typec_register_partner() does not guarantee partner registration
> > to always succeed. In the event of failure, port->partner is set
> > to the error value or NULL. Given that port->partner validity is
> > not checked, this results in the following crash:
> >
> > [17514.377076][ T275] Unable to handle kernel NULL pointer dereference at virtual address 00000000000003c0
> > [17514.378270][ T275] pc : run_state_machine+0x1bc8/0x1c08
> > [17514.378286][ T275] lr : run_state_machine+0x1b90/0x1c08
> > ..
> > [17514.378377][ T275] Call trace:
> > [17514.378381][ T275] run_state_machine+0x1bc8/0x1c08
> > [17514.378388][ T275] tcpm_state_machine_work+0x94/0xe4
> > [17514.378396][ T275] kthread_worker_fn+0x118/0x328
> > [17514.378406][ T275] kthread+0x1d0/0x23c
> > [17514.378412][ T275] ret_from_fork+0x10/0x20
>
> Nit: thre is little use in the timestamps and the T275 tag. In future
> patches you can safely ommit such data.
>
> >
> > To prevent the crash, check for port->partner validity before
> > derefencing it in all the call sites.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: c97cd0b4b54e ("usb: typec: tcpm: set initial svdm version based on pd revision")
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> > ---
> > drivers/usb/typec/tcpm/tcpm.c | 19 ++++++++++++++-----
> > 1 file changed, 14 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> > index ab6ed6111ed0..8a4fa8d875c6 100644
> > --- a/drivers/usb/typec/tcpm/tcpm.c
> > +++ b/drivers/usb/typec/tcpm/tcpm.c
> > @@ -4,7 +4,6 @@
> > *
> > * USB Power Delivery protocol stack.
> > */
> > -
> > #include <linux/completion.h>
> > #include <linux/debugfs.h>
> > #include <linux/device.h>
> > @@ -1580,7 +1579,8 @@ static void svdm_consume_identity(struct tcpm_port *port, const u32 *p, int cnt)
> > port->partner_ident.cert_stat = p[VDO_INDEX_CSTAT];
> > port->partner_ident.product = product;
> >
> > - typec_partner_set_identity(port->partner);
> > + if (!IS_ERR_OR_NULL(port->partner))
>
> I think that it might be better to check typec_register_partner() result
> in tcpm_typec_connect() and skip setting port->partner in case it
> returned an error (an error message would be also beneficial).
> See for example, how this is handled in ucsi_register_partner().
>
> Then these checks can be turned into simple `if (port->partner)`.
Sounds good ! However, I was wondering whether the error message is
redundant as typec_register_partner() also prints one. I have anyways
added that in V3.
Thanks,
Badhri
>
> > + typec_partner_set_identity(port->partner);
> >
> > tcpm_log(port, "Identity: %04x:%04x.%04x",
> > PD_IDH_VID(vdo),
> > @@ -1742,6 +1742,9 @@ static void tcpm_register_partner_altmodes(struct tcpm_port *port)
> > struct typec_altmode *altmode;
> > int i;
> >
> > + if (IS_ERR_OR_NULL(port->partner))
> > + return;
> > +
> > for (i = 0; i < modep->altmodes; i++) {
> > altmode = typec_partner_register_altmode(port->partner,
> > &modep->altmode_desc[i]);
> > @@ -4244,7 +4247,8 @@ static void tcpm_typec_connect(struct tcpm_port *port)
> > port->partner = typec_register_partner(port->typec_port,
> > &port->partner_desc);
> > port->connected = true;
> > - typec_partner_set_usb_power_delivery(port->partner, port->partner_pd);
> > + if (!IS_ERR_OR_NULL(port->partner))
> > + typec_partner_set_usb_power_delivery(port->partner, port->partner_pd);
> > }
> > }
> >
> > @@ -4323,8 +4327,10 @@ static void tcpm_typec_disconnect(struct tcpm_port *port)
> > port->plug_prime = NULL;
> > port->cable = NULL;
> > if (port->connected) {
> > - typec_partner_set_usb_power_delivery(port->partner, NULL);
> > - typec_unregister_partner(port->partner);
> > + if (!IS_ERR_OR_NULL(port->partner)) {
> > + typec_partner_set_usb_power_delivery(port->partner, NULL);
> > + typec_unregister_partner(port->partner);
> > + }
> > port->partner = NULL;
> > port->connected = false;
> > }
> > @@ -4549,6 +4555,9 @@ static enum typec_cc_status tcpm_pwr_opmode_to_rp(enum typec_pwr_opmode opmode)
> >
> > static void tcpm_set_initial_svdm_version(struct tcpm_port *port)
> > {
> > + if (IS_ERR_OR_NULL(port->partner))
> > + return;
> > +
> > switch (port->negotiated_rev) {
> > case PD_REV30:
> > break;
> >
> > base-commit: 3f12222a4bebeb13ce06ddecc1610ad32fa835dd
> > --
> > 2.44.0.769.g3c40516874-goog
> >
>
> --
> With best wishes
> Dmitry
prev parent reply other threads:[~2024-04-27 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 17:50 [PATCH v1] usb: typec: tcpm: Check for port partner validity before consuming it Badhri Jagan Sridharan
2024-04-27 19:23 ` Dmitry Baryshkov
2024-04-27 20:30 ` Badhri Jagan Sridharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTae5+gkdBmjO7Gm-tZ+5CKXAzmGOsNzEJ_ZQVb0rsaLsCU7A@mail.gmail.com \
--to=badhri@google.com \
--cc=amitsd@google.com \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdbabiera@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).