From: Johan Hovold <johan@kernel.org>
To: Coia Prant <coiaprant@gmail.com>
Cc: linux-usb@vger.kernel.org, Lars Melin <larsm17@gmail.com>,
stable@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] USB: serial: option: add Lonsung U8300/U9300 product
Date: Thu, 18 Apr 2024 09:23:06 +0200 [thread overview]
Message-ID: <ZiDKWvLJkfOidH4w@hovoldconsulting.com> (raw)
In-Reply-To: <20240415142625.1756740-1-coiaprant@gmail.com>
On Mon, Apr 15, 2024 at 07:26:25AM -0700, Coia Prant wrote:
> Update the USB serial option driver to support Longsung U8300/U9300.
> Signed-off-by: Coia Prant <coiaprant@gmail.com>
> Reviewed-by: Lars Melin <larsm17@gmail.com>
> Cc: stable@vger.kernel.org
> Cc: netdev@vger.kernel.org
> ---
Thanks for the update. Next time, remember to include a short changelog
here when revising a patch.
> drivers/usb/serial/option.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 55a65d941ccb..27a116901459 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -412,6 +412,10 @@ static void option_instat_callback(struct urb *urb);
> */
> #define LONGCHEER_VENDOR_ID 0x1c9e
>
> +/* Longsung products */
> +#define LONGSUNG_U8300_PRODUCT_ID 0x9b05
> +#define LONGSUNG_U9300_PRODUCT_ID 0x9b3c
> +
> /* 4G Systems products */
> /* This one was sold as the VW and Skoda "Carstick LTE" */
> #define FOUR_G_SYSTEMS_PRODUCT_CARSTICK_LTE 0x7605
> @@ -2054,6 +2058,10 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) },
> { USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
> { USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
> + { USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U8300_PRODUCT_ID),
> + .driver_info = RSVD(4) | RSVD(5) },
> + { USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U9300_PRODUCT_ID),
> + .driver_info = RSVD(0) | RSVD(4) },
I dropped the product defines in favour of a comment (as they don't
really add any value and we don't have to worry about keeping the
defines sorted).
I also trimmed the commit message slightly before applying.
The end-result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=cf16ffa17c398434a77b8a373e69287c95b60de2
Johan
prev parent reply other threads:[~2024-04-18 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 14:26 [PATCH 1/2 v3] USB: serial: option: add Lonsung U8300/U9300 product Coia Prant
2024-04-18 1:30 ` patchwork-bot+netdevbpf
2024-04-18 7:23 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiDKWvLJkfOidH4w@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=coiaprant@gmail.com \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).