From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D52D15821F; Wed, 24 Apr 2024 13:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713964883; cv=none; b=eWx/va08RijE0fPY1x0ILTO1MwyyblCirvl51fbm5DuyW6BcSHb/7NpUi5/MTOxYRcee7vJPMoTXUNarlMqg7H0YCX3mCHU7Wt4SOPTmEEcYzCjFWXIWspq3atFmwPka1geqTe3dfqzR/6lc56cSnfVDVEDEimbOsOyHjM9xiX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713964883; c=relaxed/simple; bh=bABuUtxtwMiaDJEDth6yYKqkY4fMD7xJ78zqRkijgc0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=d+f4eerOeh8o2zWpWiktseCsT9DvruN4cxFpblOXYXB9DCsdEaaAdx/kWcBep+qEnEvYTfc2fbtVTooam0Jelh8mtpOIYlaWvck60V6+LsabgCQ4dcLASXLNsT3CzG0N0MqC5XXf7PDA1MyMyQGMaJAlfbyUygRyQg+qrJDvMw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=oPBxCIqj; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="oPBxCIqj" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43OC4omW029734; Wed, 24 Apr 2024 14:20:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=hkSUB26Hij3YoH4d4gONssMZiD9lhMIi9MYuoDahbc0=; b=oP BxCIqjZqjU5yIPdolezp3gucfYE43BpO2moF0boJpv1s74317nNrf8tTbYX5usOd rlKx/FhS1Qy6Jkjea82P6nnIhij2k6RtqQ72RGkfOKHZzW/rYU1jige7eN6glRBm Gr/fYnvQ0nI1FFIhwyV+FpQcOob58VqnssUOpcpR/bfBeTjXY5MTu8NY0VN5oLNt baPC6vo+Z6OwTORIZk9BIz6pJZyBiWpxinx+vs127hpTMIh3Q7+NTYQB11bqSkWu wTRZ/tTR1dd1WWC/yQviBRPlU7NtgpxHp9kyOZz9PzdXYOFqZatkp9e4ugAKrRJ2 ZAcLVNQAQ/E+lH5KwgDw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3xmrnj5npa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 14:20:39 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 16FD54002D; Wed, 24 Apr 2024 14:20:30 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0C4C621A91F; Wed, 24 Apr 2024 14:19:21 +0200 (CEST) Received: from [10.48.86.79] (10.48.86.79) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 14:19:18 +0200 Message-ID: Date: Wed, 24 Apr 2024 14:19:18 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 06/13] of: property: fw_devlink: Add support for "access-controller" To: Saravana Kannan , Gatien Chevallier CC: , , , , , , , , , , , , , , , , , , , , , , , , Frank Rowand , , , , , , , , , , , , , , , , , , , , , , Rob Herring References: <20240105130404.301172-1-gatien.chevallier@foss.st.com> <20240105130404.301172-7-gatien.chevallier@foss.st.com> Content-Language: en-US From: Alexandre TORGUE In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-24_10,2024-04-23_02,2023-05-22_02 Hi Saravana On 4/24/24 07:57, Saravana Kannan wrote: > On Fri, Jan 5, 2024 at 5:03 AM Gatien Chevallier > wrote: >> >> Allows tracking dependencies between devices and their access >> controller. >> >> Signed-off-by: Gatien Chevallier >> Acked-by: Rob Herring > > Please cc me on fw_devlink patches. Also, this patch is breaking the > norm below. Please send a fix up patch. > >> --- >> Changes in V9: >> - Added Rob's review tag >> >> Changes in V6: >> - Renamed access-controller to access-controllers >> >> Changes in V5: >> - Rename feature-domain* to access-control* >> >> Patch not present in V1 >> >> drivers/of/property.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/of/property.c b/drivers/of/property.c >> index afdaefbd03f6..7f737eac91b2 100644 >> --- a/drivers/of/property.c >> +++ b/drivers/of/property.c >> @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL) >> DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) >> DEFINE_SIMPLE_PROP(panel, "panel", NULL) >> DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells") >> +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells") >> DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) >> DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") >> >> @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { >> { .parse_prop = parse_regulators, }, >> { .parse_prop = parse_gpio, }, >> { .parse_prop = parse_gpios, }, >> + { .parse_prop = parse_access_controllers, }, > > All the simple properties are listed before the suffix ones as the > suffix checks are more expensive. So, you should have inserted this > right before the suffix properties. Also, there's a merge conflict in > linux-next. So make sure you take that into account when sending the > fix up and picking the order. I'm fixing the stm32-next branch by inserting { .parse_prop = parse_access_controllers, }, just before { .parse_prop = parse_regulators, }, > > -Saravana > >> {} >> }; > >> >> -- >> 2.35.3 >>