From: R Sundar <prosunofficial@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: gregkh@linuxfoundation.org, neil.armstrong@linaro.org,
dmitry.baryshkov@linaro.org, u.kleine-koenig@pengutronix.de,
christophe.jaillet@wanadoo.fr, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH v5 linux-next] usb:typec:mux: remove indentation for common path
Date: Mon, 6 May 2024 21:39:43 +0530 [thread overview]
Message-ID: <da7a6e8c-fdda-42d3-ad42-c34e585d0ef8@gmail.com> (raw)
In-Reply-To: <Zjib5xNdpeNVfgtV@kuha.fi.intel.com>
Hi Heikki,
On 06/05/24 14:29, Heikki Krogerus wrote:
> Hi Sundar,
>
> On Fri, Apr 26, 2024 at 10:17:05PM +0530, R Sundar wrote:
>> Nitpick, Mostly common path will not be indented. so rewritten this
>> function to check device_node pointer is null and removed common path
>> indentation.
>>
>> Signed-off-by: R Sundar <prosunofficial@gmail.com>
>
> For the record, I'm still uncomfortable with the name - why not just
> spell out your whole name?
>
I understand your concern. " R Sundar ", is my whole name.
>> ---
>>
>> Fixed nitpicks in code according to comments received on other patch as
>> below:
>>
>
> Sorry for missing this earlier, but it looks like this patch only
> modifies the nb7vpq904m driver, so I think you should specify that
> already in the subject.
> While at it, you could also specify the only function that is being
> modified in the commit message (this is just a suggestion):
>
> usb: typec: nb7vpq904m: Remove uneeded indentation
>
> In function nb7vpq904m_parse_data_lanes_mapping(), the "if
> (ep)" condition is basically the entire function. Making the
> code a bit more readable by inverting the condition so that
> the function returns immedately if there is no "ep".
>
> thanks,
>
Thanks for the suggestion provided, will modify the commit message and
send the updated one.
Thanks,
Sundar
prev parent reply other threads:[~2024-05-06 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 16:47 [PATCH v5 linux-next] usb:typec:mux: remove indentation for common path R Sundar
2024-05-02 16:23 ` R Sundar
2024-05-06 8:59 ` Heikki Krogerus
2024-05-06 16:09 ` R Sundar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da7a6e8c-fdda-42d3-ad42-c34e585d0ef8@gmail.com \
--to=prosunofficial@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=skhan@linuxfoundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).