From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Huqiang Qin <huqiang.qin@amlogic.com>,
wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] dt-bindings: watchdog: Add support for Amlogic C3 SoCs
Date: Wed, 27 Sep 2023 10:01:51 +0200 [thread overview]
Message-ID: <01d8c1ea-ffce-4efc-b2a2-437403dc1d89@linaro.org> (raw)
In-Reply-To: <20230926055512.2355390-2-huqiang.qin@amlogic.com>
On 26/09/2023 07:55, Huqiang Qin wrote:
> Update dt-binding document for watchdog of Amlogic C3 SoCs.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
>
> V1 -> V2: Added compatibles.
>
> .../devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> index 443e2e7ab467..b7e8e453c0ef 100644
> --- a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> enum:
> - amlogic,meson-gxbb-wdt
> + - amlogic,c3-wdt
Nothing improved... this won't even work :/
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-27 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 5:55 [PATCH V2 0/2] Add watchdog support for Amlogic C3 SoCs Huqiang Qin
2023-09-26 5:55 ` [PATCH V2 1/2] dt-bindings: watchdog: Add " Huqiang Qin
2023-09-27 8:01 ` Krzysztof Kozlowski [this message]
2023-09-26 5:55 ` [PATCH V2 2/2] arm64: dts: Add watchdog node " Huqiang Qin
2023-09-26 8:03 ` Conor Dooley
2023-09-27 5:59 ` Huqiang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d8c1ea-ffce-4efc-b2a2-437403dc1d89@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).