From: Bharat Bhushan <bbhushan2@marvell.com>
To: <wim@linux-watchdog.org>, <inux@roeck-us.net>,
<linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: George Cherian <george.cherian@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>
Subject: [PATCH 2/2] drivers: watchdog: marvell_gti: Program the max_hw_heartbeat_ms
Date: Mon, 9 Oct 2023 10:10:37 +0530 [thread overview]
Message-ID: <20231009044037.514570-2-bbhushan2@marvell.com> (raw)
In-Reply-To: <20231009044037.514570-1-bbhushan2@marvell.com>
From: George Cherian <george.cherian@marvell.com>
Program the max_hw_heartbeat_ms value so that the watchdog_pretimeout
worker is activated. This kernel worker thread makes sure to ping the
watchdog in case the userspace is unable to do so. This kernel worker
ping will be done only till the full watchdog timeout there by
maintaining the watchdog functionality in case of a real hang.
Signed-off-by: George Cherian <george.cherian@marvell.com>
Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
---
drivers/watchdog/marvell_gti_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c
index 25b7ce0f0738..bfe0c819248c 100644
--- a/drivers/watchdog/marvell_gti_wdt.c
+++ b/drivers/watchdog/marvell_gti_wdt.c
@@ -299,6 +299,7 @@ static int gti_wdt_probe(struct platform_device *pdev)
/* Maximum timeout is 3 times the pretimeout */
wdog_dev->max_timeout = max_pretimeout * 3;
+ wdog_dev->max_hw_heartbeat_ms = max_pretimeout * 1000;
/* Minimum first timeout (pretimeout) is 1, so min_timeout as 3 */
wdog_dev->min_timeout = 3;
wdog_dev->timeout = wdog_dev->pretimeout;
--
2.34.1
next prev parent reply other threads:[~2023-10-09 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 4:40 [PATCH 1/2] drivers: watchdog: marvell_gti: fix zero pretimeout handling Bharat Bhushan
2023-10-09 4:40 ` Bharat Bhushan [this message]
2023-10-11 14:51 ` [PATCH 2/2] drivers: watchdog: marvell_gti: Program the max_hw_heartbeat_ms Guenter Roeck
2023-10-11 14:51 ` [PATCH 1/2] drivers: watchdog: marvell_gti: fix zero pretimeout handling Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009044037.514570-2-bbhushan2@marvell.com \
--to=bbhushan2@marvell.com \
--cc=george.cherian@marvell.com \
--cc=inux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).