From: Conor Dooley <conor@kernel.org>
To: Nik Bune <n2h9z4@gmail.com>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
skhan@linuxfoundation.org, baruch@tkos.co.il,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml
Date: Sun, 22 Oct 2023 18:45:27 +0100 [thread overview]
Message-ID: <20231022-sequence-munchkin-099ebb5b0573@spud> (raw)
In-Reply-To: <20231022-perish-ample-e8c009664a19@spud>
[-- Attachment #1: Type: text/plain, Size: 4150 bytes --]
On Sun, Oct 22, 2023 at 06:30:04PM +0100, Conor Dooley wrote:
> On Sun, Oct 22, 2023 at 02:03:28PM +0200, Nik Bune wrote:
> > Convert txt file to yaml.
> > Add maintainers list. Took from Documentation/devicetree/bindings/arm/digicolor.yaml file.
>
> That seems like a bit of an odd reasoning, but Baruch was the submitter
> for the original txt form binding for this watchdog , per the git history.
>
> >
> > Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> > ---
> > .../bindings/watchdog/cnxt,cx92755-wdt.yaml | 49 +++++++++++++++++++
> > .../bindings/watchdog/digicolor-wdt.txt | 25 ----------
> > 2 files changed, 49 insertions(+), 25 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> > new file mode 100644
> > index 000000000000..acd2d30b20f3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/cnxt,cx92755-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Conexant Digicolor SoCs Watchdog timer
> > +
> > +description: |
> > + The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> > + "Agent Communication" block. This block includes the eight programmable system
> > + timer counters. The first timer (called "Timer A") is the only one that can be
> > + used as watchdog.
> > +
> > +allOf:
> > + - $ref: watchdog.yaml#
> > +
> > +maintainers:
> > + - Baruch Siach <baruch@tkos.co.il>
> > +
> > +properties:
> > + compatible:
> > + const: cnxt,cx92755-wdt
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description:
> > + specifies the clock that drives the timer
>
> This can just be:
> clocks:
> maxItems: 1
>
> as clocks is a generic property & if there's only one clock, describing
> it is usually needless.
>
> Otherwise this conversion looks okay to me.
> > +
> > + timeout-sec: true
While looking at your other wd conversion I noticed this, which should
not be needed since you are referencing watchdog.yaml.
Cheers,
Conor.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + watchdog@f0000fc0 {
> > + compatible = "cnxt,cx92755-wdt";
> > + reg = <0xf0000fc0 0x8>;
> > + clocks = <&main_clk>;
> > + timeout-sec = <15>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt b/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> > deleted file mode 100644
> > index a882967e17d4..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> > +++ /dev/null
> > @@ -1,25 +0,0 @@
> > -Conexant Digicolor SoCs Watchdog timer
> > -
> > -The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> > -"Agent Communication" block. This block includes the eight programmable system
> > -timer counters. The first timer (called "Timer A") is the only one that can be
> > -used as watchdog.
> > -
> > -Required properties:
> > -
> > -- compatible : Should be "cnxt,cx92755-wdt"
> > -- reg : Specifies base physical address and size of the registers
> > -- clocks : phandle; specifies the clock that drives the timer
> > -
> > -Optional properties:
> > -
> > -- timeout-sec : Contains the watchdog timeout in seconds
> > -
> > -Example:
> > -
> > - watchdog@f0000fc0 {
> > - compatible = "cnxt,cx92755-wdt";
> > - reg = <0xf0000fc0 0x8>;
> > - clocks = <&main_clk>;
> > - timeout-sec = <15>;
> > - };
> > --
> > 2.34.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-10-22 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 12:03 [PATCH] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml Nik Bune
2023-10-22 17:30 ` Conor Dooley
2023-10-22 17:45 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022-sequence-munchkin-099ebb5b0573@spud \
--to=conor@kernel.org \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=n2h9z4@gmail.com \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).