From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: linux@roeck-us.net, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] watchdog/hpwdt: Cleanup Claiming NMI
Date: Sun, 26 Nov 2023 20:16:37 -0700 [thread overview]
Message-ID: <20231127031637.GA1267@perchik> (raw)
In-Reply-To: <20231109024407.120856-1-jerry.hoemann@hpe.com>
On Wed, Nov 08, 2023 at 07:44:05PM -0700, Jerry Hoemann wrote:
> In addition to being a watchdog, hpwdt participates in error
> containmnet on ProLiant systems.
>
> On legacy platforms (Gen 8/Gen 9 and earlier) Fatal IO errors would be
> signaled as an IO CHECK NMI with expectation that hpwdt would be present
> to receive the NMI and crash the systems thus containing the error.
>
> A problem was that hwpdt did not discriminate enough in accepting NMIs.
> This could lead to problems if an NMI generated for another subsystems
> was not claimed by that subsystem and became UNKNOWN and was claimed
> by hpwdt. Application profiling was such an example. While, profiling
> issue was fixed, hpwdt should avoid claiming NMI not intended for it.
>
> In iLO 5 time frame, checks were added to make hpwdt more selective
> in claiming NMI. This patchset cleans up the checks and enables it
> for future versions of iLO.
>
Hi Guenter,
Was there a problem with this patch set?
Thanks
Jerry
>
> Jerry Hoemann (2):
> watchdog/hpwdt: Only claim UNKNOWN NMI if from iLO
> watchdog/hpwdt: Remove checks on ilo5
>
> drivers/watchdog/hpwdt.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> --
> 2.41.0
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------
prev parent reply other threads:[~2023-11-27 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 2:44 [PATCH 0/2] watchdog/hpwdt: Cleanup Claiming NMI Jerry Hoemann
2023-11-09 2:44 ` [PATCH 1/2] watchdog/hpwdt: Only claim UNKNOWN NMI if from iLO Jerry Hoemann
2023-11-09 2:44 ` [PATCH 2/2] watchdog/hpwdt: Remove checks on ilo5 Jerry Hoemann
2023-11-27 3:16 ` Jerry Hoemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127031637.GA1267@perchik \
--to=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).