From: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
To: <xingyu.wu@starfivetech.com>
Cc: <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<jisheng.teoh@starfivetech.com>,
<krzysztof.kozlowski+dt@linaro.org>,
<krzysztof.kozlowski@linaro.org>, <leyfoon.tan@starfivetech.com>,
<linux-kernel@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
<linux@roeck-us.net>, <robh+dt@kernel.org>,
<samin.guo@starfivetech.com>, <wim@linux-watchdog.org>
Subject: Re: [PATCH v1 1/2] watchdog: starfive-wdt: Add JH8100 watchdog compatible string
Date: Tue, 12 Dec 2023 11:27:25 +0800 [thread overview]
Message-ID: <20231212032725.2524247-1-jisheng.teoh@starfivetech.com> (raw)
In-Reply-To: <e7902994-4558-4f91-b8fe-a768961683b5@starfivetech.com>
On Tue, 12 Dec 2023 11:01:21 +0800
Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
> On 2023/12/12 0:47, Ji Sheng Teoh wrote:
> > On Mon, 11 Dec 2023 11:06:42 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> >> On 09/12/2023 15:27, Ji Sheng Teoh wrote:
> >> > Add "starfive,jh8100-wdt" compatible for StarFive's JH8100
> >> > watchdog. JH8100 watchdog reuses JH7110 register mapping.
> >> >
> >> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> >> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> >> > ---
> >> > drivers/watchdog/starfive-wdt.c | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/watchdog/starfive-wdt.c
> >> > b/drivers/watchdog/starfive-wdt.c index
> >> > 5f501b41faf9..31785bb373d5 100644 ---
> >> > a/drivers/watchdog/starfive-wdt.c +++
> >> > b/drivers/watchdog/starfive-wdt.c @@ -581,6 +581,7 @@ static
> >> > const struct dev_pm_ops starfive_wdt_pm_ops = { static const
> >> > struct of_device_id starfive_wdt_match[] = { { .compatible =
> >> > "starfive,jh7100-wdt", .data = &starfive_wdt_jh7100_variant }, {
> >> > .compatible = "starfive,jh7110-wdt", .data =
> >> > &starfive_wdt_jh7110_variant },
> >> > + { .compatible = "starfive,jh8100-wdt", .data =
> >> > &starfive_wdt_jh7110_variant },
> >>
> >> Device is compatible, so why not expressing it in the bindings and
> >> dropping this change?
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > Ok, will drop this change.
> >
> > Thanks,
> > Ji Sheng
>
> Hi Ji Sheng,
>
> You can add the compatible "starfive,jh8100-wdt" in the bindings and
> add this:
>
> compatible = "starfive,jh8100-wdt", "starfive,jh7110-wdt";
>
> in the dts. I think it would be better and does not change the driver.
>
> Best regards,
> Xingyu Wu
Thanks for the suggestion, will go with this approach.
I have respin a v2 for this, as it only requires small changes.
v2: https://lore.kernel.org/all/20231212031731.2498584-2-jisheng.teoh@starfivetech.com/
next prev parent reply other threads:[~2023-12-12 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 14:27 [PATCH v1 0/2] Add StarFive JH8100 watchdog Ji Sheng Teoh
2023-12-09 14:27 ` [PATCH v1 1/2] watchdog: starfive-wdt: Add JH8100 watchdog compatible string Ji Sheng Teoh
2023-12-09 15:06 ` Guenter Roeck
2023-12-11 10:06 ` Krzysztof Kozlowski
2023-12-11 16:47 ` Ji Sheng Teoh
2023-12-12 3:01 ` Xingyu Wu
2023-12-12 3:27 ` Ji Sheng Teoh [this message]
2023-12-09 14:27 ` [PATCH v1 2/2] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh
2023-12-11 10:06 ` Krzysztof Kozlowski
2023-12-11 16:57 ` Ji Sheng Teoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212032725.2524247-1-jisheng.teoh@starfivetech.com \
--to=jisheng.teoh@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).