From: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
To: <krzysztof.kozlowski@linaro.org>
Cc: <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<jisheng.teoh@starfivetech.com>,
<krzysztof.kozlowski+dt@linaro.org>,
<leyfoon.tan@starfivetech.com>, <linux-kernel@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>, <linux@roeck-us.net>,
<robh+dt@kernel.org>, <samin.guo@starfivetech.com>,
<wim@linux-watchdog.org>, <xingyu.wu@starfivetech.com>
Subject: Re: [PATCH v3 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date: Fri, 15 Dec 2023 15:25:08 +0800 [thread overview]
Message-ID: <20231215072508.3498476-1-jisheng.teoh@starfivetech.com> (raw)
In-Reply-To: <40b5d1a8-37d2-4c68-8d16-33c92c3e5716@linaro.org>
On Thu, 14 Dec 2023 08:39:46 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 14/12/2023 04:30, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > watchdog.
> > Since JH8100 watchdog only has 1 reset signal, update binding
> > document to support one reset for "starfive,jh8100-wdt" compatible.
> >
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > ---
> > .../watchdog/starfive,jh7100-wdt.yaml | 48
> > ++++++++++++++++--- 1 file changed, 42 insertions(+), 6 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > index 68f3f6fd08a6..79082c5f9971 100644 ---
> > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > +++
> > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > @@ -19,14 +19,17 @@ description: isn't cleared, the watchdog will
> > reset the system unless the watchdog reset is disabled. -allOf:
> > - - $ref: watchdog.yaml#
> > -
> > properties:
> > compatible:
> > - enum:
> > - - starfive,jh7100-wdt
> > - - starfive,jh7110-wdt
> > + oneOf:
> > + - items:
>
> Drop items, it wasn't here in the first place.
Ok, will drop.
>
> > + - enum:
> > + - starfive,jh7100-wdt
> > + - starfive,jh7110-wdt
> > + - items:
> > + - enum:
> > + - starfive,jh8100-wdt
> > + - const: starfive,jh7110-wdt
> >
> > reg:
> > maxItems: 1
> > @@ -45,10 +48,33 @@ properties:
> > - const: core
> >
> > resets:
> > + minItems: 1
> > items:
> > - description: APB reset
> > - description: Core reset
>
> This is not valid for jh8100. Move it to else: part. Here maxItems: 2.
>
Sure, will replace with maxItems.
> >
> > +allOf:
>
> allOf goes after required:, see example-schema
>
Ok, will move it after required.
> > + - $ref: watchdog.yaml#
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - starfive,jh8100-wdt
> > + then:
> > + properties:
> > + resets:
> > + description: |
> > + Must contain Core reset entry.
> > + maxItems: 1
>
> Instead of both, items: with description.
>
Sure, will use items instead.
> > + else:
> > + properties:
> > + resets:
> > + description: |
> > + Must contain APB reset and Core reset entry.
> > + minItems: 2
> > +
> > required:
> > - compatible
> > - reg
> > @@ -69,3 +95,13 @@ examples:
> > resets = <&rst 99>,
> > <&rst 100>;
> > };
> > +
> > + - |
> > + watchdog@12270000 {
> > + compatible = "starfive,jh8100-wdt", "starfive,jh7110-wdt";
> > + reg = <0x12270000 0x10000>;
> > + clocks = <&clk 78>,
> > + <&clk 79>;
>
> No need for new example with difference in one property.
Ok, will drop the new example. Thanks
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-12-15 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 3:30 [PATCH v3 0/1] Add StarFive JH8100 watchdog Ji Sheng Teoh
2023-12-14 3:30 ` [PATCH v3 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh
2023-12-14 7:39 ` Krzysztof Kozlowski
2023-12-15 7:25 ` Ji Sheng Teoh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215072508.3498476-1-jisheng.teoh@starfivetech.com \
--to=jisheng.teoh@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).