From: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Mukesh Ojha <quic_mojha@quicinc.com>,
Pavankumar Kondeti <quic_pkondeti@quicinc.com>
Subject: [PATCH] watchdog: qcom: Start the watchdog in probe
Date: Wed, 31 Jan 2024 09:45:40 +0530 [thread overview]
Message-ID: <20240131-qcom-wdt-start-probe-v1-1-bee0a86e2bba@quicinc.com> (raw)
When CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED is enabled, kernel can pet the
watchdog until user space takes over. Make use of this feature and
start the watchdog in probe.
Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
---
drivers/watchdog/qcom-wdt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
index 9e790f0c2096..4fb5dbf5faee 100644
--- a/drivers/watchdog/qcom-wdt.c
+++ b/drivers/watchdog/qcom-wdt.c
@@ -276,12 +276,16 @@ static int qcom_wdt_probe(struct platform_device *pdev)
watchdog_init_timeout(&wdt->wdd, 0, dev);
/*
+ * Kernel can pet the watchdog until user space takes over.
+ * Start the watchdog here to make use of this feature.
+ *
* If WDT is already running, call WDT start which
* will stop the WDT, set timeouts as bootloader
* might use different ones and set running bit
* to inform the WDT subsystem to ping the WDT
*/
- if (qcom_wdt_is_running(&wdt->wdd)) {
+ if (IS_ENABLED(CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED) ||
+ qcom_wdt_is_running(&wdt->wdd)) {
qcom_wdt_start(&wdt->wdd);
set_bit(WDOG_HW_RUNNING, &wdt->wdd.status);
}
---
base-commit: 41bccc98fb7931d63d03f326a746ac4d429c1dd3
change-id: 20240131-qcom-wdt-start-probe-b8e0560aef7d
Best regards,
--
Pavankumar Kondeti <quic_pkondeti@quicinc.com>
next reply other threads:[~2024-01-31 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 4:15 Pavankumar Kondeti [this message]
2024-01-31 6:01 ` [PATCH] watchdog: qcom: Start the watchdog in probe Guenter Roeck
2024-01-31 6:16 ` Pavan Kondeti
2024-01-31 6:37 ` Guenter Roeck
2024-01-31 6:51 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131-qcom-wdt-start-probe-v1-1-bee0a86e2bba@quicinc.com \
--to=quic_pkondeti@quicinc.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quic_mojha@quicinc.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).