From: Peter Griffin <peter.griffin@linaro.org>
To: arnd@arndb.de, krzysztof.kozlowski@linaro.org,
linux@roeck-us.net, wim@linux-watchdog.org,
alim.akhtar@samsung.com, jaewon02.kim@samsung.com,
semen.protsenko@linaro.org
Cc: alexey.klimov@linaro.org, kernel-team@android.com,
peter.griffin@linaro.org, tudor.ambarus@linaro.org,
andre.draszik@linaro.org, saravanak@google.com,
willmcvicker@google.com, linux-fsd@tesla.com,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v6 0/2] Add regmap support to exynos-pmu for protected PMU regs
Date: Tue, 20 Feb 2024 22:06:11 +0000 [thread overview]
Message-ID: <20240220220613.797068-1-peter.griffin@linaro.org> (raw)
Hi folks,
This is a v6 of the series to add support for protected PMU registers found
on gs101 and derivative SoCs. In v2 and later it was re-worked to be based
on a regmap abstraction that I think leads to a much neater overall
solution.
The advantage of the regmap abstraction is that most leaf drivers that
read/write PMU registers need minimal changes.
Example of Exynos drivers that require PMU register access are:
* watchdog
* usb phy
* mipi phy
* ufs phy
This series has been tested on Pixel 6 Oriole / gs101 (by me), exynos850
(by Sam) and odroid xu3 (exynos 5422) by Alexey. That confirms that both
the regmap mmio parts and regmap SMC parts are working correctly.
The expectation is this series would be merged via Krzysztofs Samsung Exynos
tree.
regards,
Peter
Changes since v5:
- Update kerneldoc comment property -> propname
Changes since v4:
- Use same argument names as in struct regmap_config
- Remove inline keyword and rely on compiler
- Update kerneldoc wording
- property -> propname argument rename
- reverse Xmas tree
- Only call of_node_put() when of_parse_phandle() is called
- Collect tags
Changes since v3:
- Fix PMUALIVE_MASK
- Add TENSOR_ prefix
- clear SET_BITS bits on each loop iteration
- change set_bit to set_bits func name
- Fix some alignment
- Add missing return on dev_err_probe
- Reduce indentation in loop
Changes since v2
- Add select REGMAP to Kconfig
- Add constant for SET/CLEAR bits
- Replace kerneldoc with one line comment
- Fix kerneldoc for EXPORT_SYMBOL_GPL funcs
- remove superfluous extern keyword
- dev_err_probe() on probe error
- shorten regmcfg name
- no compatibles inside probe, use match data
- don't mix declarations with/without initializations
- tensor_sec_reg_read() use mmio to avoid access restrictions
- Collect up Reviewed-by
- const for regmap_config structs
Changes since v1:
- Refactor to use custom regmap to abstract SMC register access (Sam / Guenter)
- Add deferred probing support (Saravana / Krzysztof)
v5 lore: https://lore.kernel.org/all/20240219204238.356942-1-peter.griffin@linaro.org/
v4 lore: https://lore.kernel.org/all/20240208161700.268570-1-peter.griffin@linaro.org/
v3 lore: https://lore.kernel.org/all/20240202145731.4082033-1-peter.griffin@linaro.org/
v2 lore: https://lore.kernel.org/lkml/20240129211912.3068411-1-peter.griffin@linaro.org/
v1 lore: https://lore.kernel.org/all/20240122225710.1952066-1-peter.griffin@linaro.org/
Peter Griffin (2):
soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU
regs
watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU
regs
drivers/soc/samsung/Kconfig | 1 +
drivers/soc/samsung/exynos-pmu.c | 235 ++++++++++++++++++++++++-
drivers/soc/samsung/exynos-pmu.h | 1 +
drivers/watchdog/Kconfig | 1 -
drivers/watchdog/s3c2410_wdt.c | 8 +-
include/linux/soc/samsung/exynos-pmu.h | 11 +-
6 files changed, 249 insertions(+), 8 deletions(-)
--
2.44.0.rc0.258.g7320e95886-goog
next reply other threads:[~2024-02-20 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:06 Peter Griffin [this message]
2024-02-20 22:06 ` [PATCH v6 1/2] soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs Peter Griffin
2024-02-20 22:06 ` [PATCH v6 2/2] watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for " Peter Griffin
2024-02-25 10:41 ` [PATCH v6 0/2] Add regmap support to exynos-pmu for protected " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220220613.797068-1-peter.griffin@linaro.org \
--to=peter.griffin@linaro.org \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=jaewon02.kim@samsung.com \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=saravanak@google.com \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).