From: Peter Yin <peteryin.openbmc@gmail.com>
To: patrick@stwcx.xyz, Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Eddie James <eajames@linux.vnet.ibm.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH v9 0/1] watchdog: aspeed: Revise handling of bootstatus
Date: Tue, 30 Apr 2024 22:31:13 +0800 [thread overview]
Message-ID: <20240430143114.1323686-1-peteryin.openbmc@gmail.com> (raw)
Regarding the AST2600 specification, the WDTn Timeout Status Register
(WDT10) has bit 1 reserved. Bit 1 of the status register indicates
on ast2500 if the boot was from the second boot source.
It does not indicate that the most recent reset was triggered by
the watchdog. The code should just be changed to set WDIOF_CARDRESET
if bit 0 of the status register is set. However, this bit can be clear when
watchdog register 0x0c bit1(Reset System after timeout) is enabled.
Thereforce include SCU register to veriy WDIOF_EXTERN1 and WDIOF_CARDRESET
in ast2600 SCU74 or ast2400/ast2500 SCU3C.
Change Log:
v8 -> v9
- Rename and restructure the SCU.
v7 -> v8
- Simplify the code.
v6 -> v7
- To use syscon_regmap_lookup_by_compatibleys to get scu base
- Power on reset is set when triggered by AC or SRSRST.
Thereforce, we clear flag to ensure next boot cause is a real watchdog case.
We use the external reset flag to determine
if it is an external reset or card reset.
v5 -> v6
- Fixed missing WDT_TIMEOUT_STATUS_EVENT.
v4 -> v5
- Revert indentation.
v3 -> v4
- Add error handling for syscon_regmap_lookup_by_phandle and
regmap_read.
v2 -> v3
- Fixed WDIOF_CARDRESET status bit check and added support
for WDIOF_EXTERN1 on ast2500 and ast2600.
v1 -> v2
- Add comment and support WDIOF_CARDRESET in ast2600
v1
- Patch 0001 - Add WDIOF_EXTERN1 bootstatus
---
drivers/watchdog/aspeed_wdt.c | 90 +++++++++++++++++++++++++++++++----
1 file changed, 82 insertions(+), 8 deletions(-)
--
2.25.1
next reply other threads:[~2024-04-30 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 14:31 Peter Yin [this message]
2024-04-30 14:31 ` [PATCH v9 1/1] watchdog: aspeed: Revise handling of bootstatus Peter Yin
2024-05-01 1:44 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430143114.1323686-1-peteryin.openbmc@gmail.com \
--to=peteryin.openbmc@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=eajames@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).