From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v1 1/6] dt-bindings: ROHM BD96801 PMIC regulators
Date: Fri, 3 May 2024 10:25:26 +0300 [thread overview]
Message-ID: <2286c7cd-6510-407a-817a-8d964b158c4c@gmail.com> (raw)
In-Reply-To: <74655775-a8e2-45f4-8a1b-8046dffa5520@gmail.com>
On 5/3/24 07:54, Matti Vaittinen wrote:
> Hi Conor,
>
> On 5/2/24 19:20, Conor Dooley wrote:
>> On Tue, Apr 30, 2024 at 02:59:50PM +0300, Matti Vaittinen wrote:
>>
>> Krzysztof had some comments on the buck/ldo node names
>
> I think Krzysztof pointed out that the regulator-name property should
> not match the data-sheet but the board. If he had something to say about
> the node names, then I've missed his comment!
>
>> and on the
>> initial value properties that I'm not sure if have been addressed, so
>> gonna leave this series to him.
>
> Thanks for pointing out I may have missed addressing some of his
> concerns. I though I fixed all issues he pointed to me but it may be I
> missed some - or accidentally dropped some change(s) when merging fixes
> from the 'experimental' branch to the 'simple'. I'll revise Krzysztof's
> feedback to the RFC before sending the next version!
You were right Conor. I checked it and yes, I omitted a few of the fixes
to regulator bindings. Please skip reviewing this version of these
bindings, I'll handle the rest of the comments in next one!
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2024-05-03 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 11:59 [PATCH v1 0/6] Support ROHM BD96801 scalable PMIC Matti Vaittinen
2024-04-30 11:59 ` [PATCH v1 1/6] dt-bindings: ROHM BD96801 PMIC regulators Matti Vaittinen
2024-05-02 16:20 ` Conor Dooley
2024-05-03 4:54 ` Matti Vaittinen
2024-05-03 7:25 ` Matti Vaittinen [this message]
2024-04-30 12:00 ` [PATCH v1 2/6] dt-bindings: mfd: bd96801 PMIC core Matti Vaittinen
2024-04-30 12:00 ` [PATCH v1 3/6] mfd: support ROHM BD96801 " Matti Vaittinen
2024-05-03 7:41 ` Lee Jones
2024-05-03 8:43 ` Matti Vaittinen
2024-04-30 12:01 ` [PATCH v1 4/6] regulator: bd96801: ROHM BD96801 PMIC regulators Matti Vaittinen
2024-04-30 12:01 ` [PATCH v1 5/6] watchdog: ROHM BD96801 PMIC WDG driver Matti Vaittinen
2024-04-30 16:24 ` Guenter Roeck
2024-05-01 10:16 ` Matti Vaittinen
2024-04-30 12:02 ` [PATCH v1 6/6] MAINTAINERS: Add ROHM BD96801 'scalable PMIC' entries Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2286c7cd-6510-407a-817a-8d964b158c4c@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).