From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"David Ober" <dober@lenovo.com>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: LENOVO_SE10_WDT should depend on X86 && DMI
Date: Tue, 07 May 2024 06:59:57 -0400 [thread overview]
Message-ID: <39139c19-cf91-4e25-a52b-876d0880f5ed@app.fastmail.com> (raw)
In-Reply-To: <58005595a05ef803b454b78d3ae9b8ee0675bd5d.1715076440.git.geert+renesas@glider.be>
Thanks Geert,
On Tue, May 7, 2024, at 6:07 AM, Geert Uytterhoeven wrote:
> The Lenovo SE10 watchdog is only present on Lenovo ThinkEdge SE10
> platforms, which are based on Intel Atom SoCs, and its driver relies on
> DMI tables. Hence add dependencies on X86 && DMI, to prevent asking the
> user about this driver when configuring a kernel without Intel Atom or
> DMI support.
>
> While at it, fix the odd indentation (spaces instead of TABs).
>
> Fixes: 1f6602c8ed1eccac ("watchdog: lenovo_se10_wdt: Watchdog driver
> for Lenovo SE10 platform")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/watchdog/Kconfig | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 24dfecbb30157fff..f002e9627c076f1f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -255,14 +255,15 @@ config GPIO_WATCHDOG_ARCH_INITCALL
> If in doubt, say N.
>
> config LENOVO_SE10_WDT
> - tristate "Lenovo SE10 Watchdog"
> - select WATCHDOG_CORE
> - help
> - If you say yes here you get support for the watchdog
> - functionality for the Lenovo SE10 platform.
> -
> - This driver can also be built as a module. If so, the module
> - will be called lenovo-se10-wdt.
> + tristate "Lenovo SE10 Watchdog"
> + depends on (X86 && DMI) || COMPILE_TEST
> + select WATCHDOG_CORE
> + help
> + If you say yes here you get support for the watchdog
> + functionality for the Lenovo SE10 platform.
> +
> + This driver can also be built as a module. If so, the module
> + will be called lenovo-se10-wdt.
>
> config MENF21BMC_WATCHDOG
> tristate "MEN 14F021P00 BMC Watchdog"
> --
> 2.34.1
Looks good to me. And apologies on the spaces being wrong in the first place.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark
next prev parent reply other threads:[~2024-05-07 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 10:07 [PATCH] watchdog: LENOVO_SE10_WDT should depend on X86 && DMI Geert Uytterhoeven
2024-05-07 10:59 ` Mark Pearson [this message]
2024-05-07 13:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39139c19-cf91-4e25-a52b-876d0880f5ed@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=dober@lenovo.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).