From: Andrew Davis <afd@ti.com>
To: Nik Bune <n2h9z4@gmail.com>, <wim@linux-watchdog.org>,
<linux@roeck-us.net>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<skhan@linuxfoundation.org>, <m-karicheri2@ti.com>,
<ivan.khoronzhuk@ti.com>
Cc: <linux-watchdog@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: watchdog: davinci-wdt: convert txt to yaml
Date: Tue, 24 Oct 2023 15:55:23 -0500 [thread overview]
Message-ID: <41408db6-89f9-4e0b-b407-96c6c922e8a4@ti.com> (raw)
In-Reply-To: <20231024195839.49607-1-n2h9z4@gmail.com>
On 10/24/23 2:58 PM, Nik Bune wrote:
> Convert txt file to yaml.
> Add maintainers list, based on the git history.
> Mark clock as required property, by reviewer's suggestion.
>
> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> ---
>
> Changes in v2 (according to review comments):
> - Added clocks to the list of required properties.
> - Updated clocks property to have only maxItems without $ref and description.
> - Removed timeout-sec explicit definition, as it is defined in watchdog.yaml.
> - Updated maintainers list from the git history.
>
> v1 patch: https://lore.kernel.org/all/20231021171323.113208-1-n2h9z4@gmail.com/
>
> .../bindings/watchdog/davinci-wdt.txt | 24 ----------
> .../bindings/watchdog/ti,davinci-wdt.yaml | 47 +++++++++++++++++++
> 2 files changed, 47 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
> deleted file mode 100644
> index aa10b8ec36e2..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller
> -
> -Required properties:
> -- compatible : Should be "ti,davinci-wdt", "ti,keystone-wdt"
> -- reg : Should contain WDT registers location and length
> -
> -Optional properties:
> -- timeout-sec : Contains the watchdog timeout in seconds
> -- clocks : the clock feeding the watchdog timer.
> - Needed if platform uses clocks.
> - See clock-bindings.txt
> -
> -Documentation:
> -Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf
> -Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf
> -
> -Examples:
> -
> -wdt: wdt@2320000 {
> - compatible = "ti,davinci-wdt";
> - reg = <0x02320000 0x80>;
> - timeout-sec = <30>;
> - clocks = <&clkwdtimer0>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml
> new file mode 100644
> index 000000000000..4747be98b7d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller
> +
> +description: |
> + Documentation:
> + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf
> + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a
> +
> +maintainers:
> + - Murali Karicheri <m-karicheri2@ti.com>
> + - Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Neither of these folks will be available for this, you can use me if
you want an email that won't bounce for now.
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - ti,davinci-wdt
> + - ti,keystone-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
We also have some instances with an optional power-domains prop.
power-domains:
description: A phandle and PM domain specifier as defined by bindings of
the power controller specified by phandle. See
Documentation/devicetree/bindings/power/power-domain.yaml for details.
Andrew
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + watchdog@2320000 {
> + compatible = "ti,davinci-wdt";
> + reg = <0x02320000 0x80>;
> + timeout-sec = <30>;
> + clocks = <&clkwdtimer0>;
> + };
next prev parent reply other threads:[~2023-10-24 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 19:58 [PATCH v2] dt-bindings: watchdog: davinci-wdt: convert txt to yaml Nik Bune
2023-10-24 20:55 ` Andrew Davis [this message]
2023-10-26 20:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41408db6-89f9-4e0b-b407-96c6c922e8a4@ti.com \
--to=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.khoronzhuk@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m-karicheri2@ti.com \
--cc=n2h9z4@gmail.com \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).