From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
p.zabel@pengutronix.de, geert+renesas@glider.be,
magnus.damm@gmail.com, biju.das.jz@bp.renesas.com,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
Date: Wed, 14 Feb 2024 17:51:27 +0200 [thread overview]
Message-ID: <497c4fb6-1ea1-4e14-bd43-ce4a4441694e@tuxon.dev> (raw)
In-Reply-To: <CAMuHMdU8iJhXWFTrVqr8W-ov2D=oSUbsyDP1kfs6mC3rBcLxzQ@mail.gmail.com>
Hi, Geert,
On 14.02.2024 17:26, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> On Fri, Feb 9, 2024 at 1:25 PM claudiu beznea <claudiu.beznea@tuxon.dev> wrote:
>> On 08.02.2024 14:53, Geert Uytterhoeven wrote:
>>> On Thu, Feb 8, 2024 at 1:26 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>>
>>>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>>>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>>>> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>>>>
>>>> Suggested-by: Guenter Roeck <linux@roeck-us.net>
>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>> ---
>>>>
>>>> Changes in v6:
>>>> - update patch description
>>>> - fixed the dependency on COMPILE_TEST previously introduced
>>>
>>> Thanks for the update!
>>>
>>>> --- a/drivers/watchdog/Kconfig
>>>> +++ b/drivers/watchdog/Kconfig
>>>> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
>>>> config RENESAS_RZG2LWDT
>>>> tristate "Renesas RZ/G2L WDT Watchdog"
>>>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>>>> + depends on PM
>>>
>>> depends on PM || COMPILE_TEST
>>
>> Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
>> defined, they are connected with '&&'") the above:
>>
>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>> depends on PM
>>
>> are translated into:
>> depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
>>
>> Please let me know if I'm wrong.
>
> That is correct. But you still can compile-test this driver when
> compiling for a different platform, and CONFIG_PM is disabled.
Ok, I see, thank you!
>
> Gr{oetje,eeting}s,
>
> Geert
>
next prev parent reply other threads:[~2024-02-14 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 10:58 [PATCH v6 0/9] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-02-08 10:58 ` [PATCH v6 1/9] watchdog: rzg2l_wdt: Restrict the driver to ARCH_RZG2L and ARCH_R9A09G011 Claudiu
2024-02-08 10:58 ` [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM Claudiu
2024-02-08 12:53 ` Geert Uytterhoeven
2024-02-08 13:02 ` claudiu beznea
2024-02-14 15:26 ` Geert Uytterhoeven
2024-02-14 15:51 ` claudiu beznea [this message]
2024-02-08 10:58 ` [PATCH v6 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-02-08 10:58 ` [PATCH v6 4/9] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-02-08 10:58 ` [PATCH v6 5/9] watchdog: rzg2l_wdt: Remove reset de-assert from probe Claudiu
2024-02-08 10:58 ` [PATCH v6 6/9] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-02-08 10:58 ` [PATCH v6 7/9] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-02-08 10:58 ` [PATCH v6 8/9] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-02-08 10:58 ` [PATCH v6 9/9] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497c4fb6-1ea1-4e14-bd43-ce4a4441694e@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).