From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D91C25B47 for ; Fri, 27 Oct 2023 11:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231461AbjJ0LAz (ORCPT ); Fri, 27 Oct 2023 07:00:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbjJ0LAw (ORCPT ); Fri, 27 Oct 2023 07:00:52 -0400 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9DED191; Fri, 27 Oct 2023 04:00:49 -0700 (PDT) Received: from hatter.bewilderbeest.net (unknown [IPv6:2602:61:7e5d:5300::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 1871F912; Fri, 27 Oct 2023 04:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1698404449; bh=46CI2348zLuWGtq6JcTrLbZwqAqPdJ4oLHt47Q46BLU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gvYXJhSfFqFnNUZNLH6mGrPgpLf5hM+XUJqMFmDnq4vz+FXeaqBzpT57FN/cpXgC6 CW0MDbyUQXnYZEFiyKVzv0eIeg3oCh6m/ZuFuBgDa+vkhfXYyWgxybN42GIr5s4sz1 kcR5PICg9oa5uPjczQH5kX3MM7VI8FE5gyfcbPko= Date: Fri, 27 Oct 2023 04:00:47 -0700 From: Zev Weiss To: Andrew Jeffery , Conor Dooley , Guenter Roeck , Joel Stanley , Krzysztof Kozlowski , "Milton D. Miller II" , Rob Herring , Wim Van Sebroeck , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, openbmc@lists.ozlabs.org Cc: Eddie James , Ivan Mikhaylov , Thomas =?iso-8859-1?Q?Wei=DFschuh?= Subject: Re: [PATCH 0/2] watchdog: aspeed: Add aspeed,reset-mask property Message-ID: <5db80b63-65da-407c-a019-048dea8c1a89@hatter.bewilderbeest.net> References: <20230922104231.1434-4-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20230922104231.1434-4-zev@bewilderbeest.net> Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Fri, Sep 22, 2023 at 03:42:32AM PDT, Zev Weiss wrote: >Hello, > >These patches add a new aspeed,reset-mask DT property for the Aspeed >watchdog timer, which specifies exactly which peripherals should be >reset by the watchdog timer. > >This series is a replacement for a patch I sent earlier [0], though >using an entirely different (DT-based) approach and hence not exactly >a v2. > >I've tested these patches on ast2500 hardware and a qemu ast2600 >model; test results on actual ast2600 hardware would be welcome. > > >Thanks, >Zev > > >[0] https://lore.kernel.org/linux-watchdog/20230922013542.29136-2-zev@bewilderbeest.net/ > >Zev Weiss (2): > dt-bindings: watchdog: aspeed-wdt: Add aspeed,reset-mask property > watchdog: aspeed: Add support for aspeed,reset-mask DT property > > .../bindings/watchdog/aspeed-wdt.txt | 18 +++- > drivers/watchdog/aspeed_wdt.c | 11 +++ > include/dt-bindings/watchdog/aspeed-wdt.h | 92 +++++++++++++++++++ > 3 files changed, 120 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/watchdog/aspeed-wdt.h > Ping...Guenter, if we stick with the simpler approach in this version of the patches (which I'm fine with and seems to have passed muster with Rob & Joel) does this look okay as is? Thanks, Zev