From: Guenter Roeck <linux@roeck-us.net>
To: Mark Pearson <mpearson@squebb.ca>,
David Ober <dober6023@gmail.com>,
wim@linux-watchdog.org
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
David Ober <dober@lenovo.com>
Subject: Re: [PATCH v3] Watchdog: New module for ITE 5632 watchdog
Date: Fri, 23 Feb 2024 12:21:51 -0800 [thread overview]
Message-ID: <6b0373a2-7750-4d57-8839-95c6fa30c6b8@roeck-us.net> (raw)
In-Reply-To: <a361ce91-beba-43d8-b969-285063658da5@app.fastmail.com>
On 2/23/24 11:58, Mark Pearson wrote:
> On Fri, Jul 21, 2023, at 8:29 AM, David Ober wrote:
>> This modules is to allow for the new ITE 5632 EC chip
>> to support the watchdog for initial use in the Lenovo SE10
>>
>> Signed-off-by: David Ober <dober6023@gmail.com>
>>
>> V2 Fix stop to deactivate wdog on unload of module
>> V2 Remove extra logging that is not needed
>> V2 change udelays to usleep_range
>> V2 Changed to now request region on start and release on stop instead
>> of for every ping and read/write
>> V3 add counter to while loops so it will not hang
>> V3 rework code to use platform_device_register_simple
>> V3 rework getting the Chip ID to remove duplicate code and close IO
>> V3 change some extra logging to be debug only
>> ---
[ ... ]
>> +config ITE5632_WDT
>> + tristate "ITE 5632"
>> + select WATCHDOG_CORE
>> + help
>> + If you say yes here you get support for the watchdog
>> + functionality of the ITE 5632 eSIO chip.
>> +
>> + This driver can also be built as a module. If so, the module
>> + will be called ite5632_wdt.
>> +
[ ... ]
>
>
> Please let us know if there is anything else needed to get this accepted. Happy to address any feedback.
>
I am sure I commented on this before. The fact that the Lenovo SE10 uses an
ITE 5632 controller is completely irrelevant. Lenovo could decide tomorrow to
replace the ITE chip with a Nuvoton chip, use the same API to talk with it,
and the watchdog would work perfectly fine.
This is a driver for the watchdog implemented in the embedded controller
on Lenovo SE10. It is not a watchdog driver for ITE5632. Again, the EC chip
used in that Lenovo system is completely irrelevant, even more so since
this seems to be one of those undocumented ITE chips which officially
don't even exist. Claiming that this would be a watchdog driver for ITE5632
would be not only misleading but simply wrong.
It seems that we can not agree on this. That means that, from my perspective,
there is no real path to move forward. Wim will have to decide if and how
to proceed.
Thanks,
Guenter
next prev parent reply other threads:[~2024-02-23 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 12:29 [PATCH v3] Watchdog: New module for ITE 5632 watchdog David Ober
2024-02-23 19:58 ` Mark Pearson
2024-02-23 20:21 ` Guenter Roeck [this message]
2024-02-24 0:43 ` Mark Pearson
2024-02-24 15:49 ` Guenter Roeck
2024-02-24 20:19 ` Mark Pearson
2024-02-25 6:43 ` Guenter Roeck
2024-02-26 16:23 ` Mark Pearson
2024-02-29 16:40 ` Mark Pearson
2024-02-29 17:25 ` Guenter Roeck
2024-02-29 18:12 ` Mark Pearson
2024-02-29 18:47 ` Guenter Roeck
2024-02-29 19:15 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0373a2-7750-4d57-8839-95c6fa30c6b8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dober6023@gmail.com \
--cc=dober@lenovo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mpearson@squebb.ca \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).