From: Prarit Bhargava <prarit@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
David Arcari <darcari@redhat.com>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: Provide a better stop error message
Date: Tue, 5 Dec 2023 09:42:55 -0500 [thread overview]
Message-ID: <7dd6f44c-0f4b-4127-83fc-a8cf7e6314c1@redhat.com> (raw)
In-Reply-To: <856c571a-41be-4e5e-9bde-72a192b14801@roeck-us.net>
On 12/5/23 09:32, Guenter Roeck wrote:
> On 12/5/23 06:09, Prarit Bhargava wrote:
>> Provide a better stop error message for the case where the watchdog does
>> not stop.
>>
>
> Please, no such patches. We are busy enough as is, and we don't need
> people to change log messages they don't like.
>
It is impossible to tell what actually happened without the additional
information (specifically the current thread). That's not a "don't
like" as much as it is a "provide better debug output".
P.
> Guenter
>
prev parent reply other threads:[~2023-12-05 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 14:09 [PATCH] watchdog: Provide a better stop error message Prarit Bhargava
2023-12-05 14:32 ` Guenter Roeck
2023-12-05 14:42 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd6f44c-0f4b-4127-83fc-a8cf7e6314c1@redhat.com \
--to=prarit@redhat.com \
--cc=darcari@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).