From: Guenter Roeck <linux@roeck-us.net>
To: Werner Fischer <devlists@wefi.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 4/4] watchdog: it87_wdt: Keep WDTCTRL bit 3 unmodified for IT8784/IT8786
Date: Wed, 13 Dec 2023 06:54:34 -0800 [thread overview]
Message-ID: <80058559-d489-497c-b07b-ca41d5a950b5@roeck-us.net> (raw)
In-Reply-To: <20231213094525.11849-4-devlists@wefi.net>
On Wed, Dec 13, 2023 at 10:45:25AM +0100, Werner Fischer wrote:
> WDTCTRL bit 3 sets the mode choice for the clock input of IT8784/IT8786.
> Some motherboards require this bit to be set to 1 (= PCICLK mode),
> otherwise the watchdog functionality gets broken. The BIOS of those
> motherboards sets WDTCTRL bit 3 already to 1.
>
> Instead of setting all bits of WDTCTRL to 0 by writing 0x00 to it, keep
> bit 3 of it unchanged for IT8784/IT8786 chips. In this way, bit 3 keeps
> the status as set by the BIOS of the motherboard.
>
> Watchdog tests have been successful with this patch with the following
> systems:
> IT8784: Thomas-Krenn LES plus v2 (YANLING YL-KBRL2 V2)
> IT8786: Thomas-Krenn LES plus v3 (YANLING YL-CLU L2)
> IT8786: Thomas-Krenn LES network 6L v2 (YANLING YL-CLU6L)
>
> Link: https://lore.kernel.org/all/140b264d-341f-465b-8715-dacfe84b3f71@roeck-us.net/
>
> Signed-off-by: Werner Fischer <devlists@wefi.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it87_wdt.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index f6a344c002af..9297a5891912 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -258,6 +258,7 @@ static struct watchdog_device wdt_dev = {
> static int __init it87_wdt_init(void)
> {
> u8 chip_rev;
> + u8 ctrl;
> int rc;
>
> rc = superio_enter();
> @@ -316,7 +317,18 @@ static int __init it87_wdt_init(void)
>
> superio_select(GPIO);
> superio_outb(WDT_TOV1, WDTCFG);
> - superio_outb(0x00, WDTCTRL);
> +
> + switch (chip_type) {
> + case IT8784_ID:
> + case IT8786_ID:
> + ctrl = superio_inb(WDTCTRL);
> + ctrl &= 0x08;
> + superio_outb(ctrl, WDTCTRL);
> + break;
> + default:
> + superio_outb(0x00, WDTCTRL);
> + }
> +
> superio_exit();
>
> if (timeout < 1 || timeout > max_units * 60) {
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-12-13 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 9:45 [PATCH 1/4] watchdog: it87_wdt: add blank line after variable declaration Werner Fischer
2023-12-13 9:45 ` [PATCH 2/4] watchdog: it87_wdt: Remove redundant max_units setting Werner Fischer
2023-12-13 14:54 ` Guenter Roeck
2023-12-13 9:45 ` [PATCH 3/4] watchdog: it87_wdt: Add IT8659 ID Werner Fischer
2023-12-13 14:54 ` Guenter Roeck
2023-12-13 9:45 ` [PATCH 4/4] watchdog: it87_wdt: Keep WDTCTRL bit 3 unmodified for IT8784/IT8786 Werner Fischer
2023-12-13 14:54 ` Guenter Roeck [this message]
2023-12-13 14:54 ` [PATCH 1/4] watchdog: it87_wdt: add blank line after variable declaration Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80058559-d489-497c-b07b-ca41d5a950b5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devlists@wefi.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).