From: Guenter Roeck <linux@roeck-us.net>
To: "Łukasz Majczak" <lma@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Radoslaw Biernacki <biernacki@google.com>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog
Date: Thu, 18 Jan 2024 10:17:50 -0800 [thread overview]
Message-ID: <82563d8e-5987-4a1b-8265-22d20f8d6902@roeck-us.net> (raw)
In-Reply-To: <CAE5UKNpLmN0sKktML1+hEzgRkHKS_X_wv==MPV8G5djeG+B9FA@mail.gmail.com>
On 1/18/24 10:08, Łukasz Majczak wrote:
> Hi Guenter
>
> Please see my comments below
>
> On Wed, Jan 17, 2024 at 5:23 PM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 1/17/24 02:24, Lukasz Majczak wrote:
>>> This adds EC-based watchdog support for ChromeOS
>>> based devices equipped with embedded controller (EC).
>>>
>>> Signed-off-by: Lukasz Majczak <lma@chromium.org>
>>
>> checkpatch --strict says:
>>
>> total: 0 errors, 0 warnings, 14 checks, 455 lines checked
>>
>> Please fix.
>
> ACK, Although I would keep uint16_t/uint32_t types in
> cros_ec_commands.h as those are shared with EC firmware.
>
Makes sense. Thanks!
Guenter
prev parent reply other threads:[~2024-01-18 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 10:24 [PATCH] drivers: watchdog: Add ChromeOS EC watchdog Lukasz Majczak
2024-01-17 15:27 ` Krzysztof Kozlowski
2024-01-18 17:28 ` Łukasz Majczak
2024-01-17 15:29 ` Krzysztof Kozlowski
2024-01-17 16:23 ` Guenter Roeck
2024-01-18 18:08 ` Łukasz Majczak
2024-01-18 18:17 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82563d8e-5987-4a1b-8265-22d20f8d6902@roeck-us.net \
--to=linux@roeck-us.net \
--cc=biernacki@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gwendal@chromium.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lma@chromium.org \
--cc=tzungbi@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).