From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nik Bune <n2h9z4@gmail.com>,
wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
skhan@linuxfoundation.org, stigge@antcom.de
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: nxp,pnx4008-wdt: convert txt to yaml
Date: Sun, 5 Nov 2023 19:30:08 +0100 [thread overview]
Message-ID: <894de0ea-d532-4bf3-88ae-91c766e703c5@linaro.org> (raw)
In-Reply-To: <20231104182813.80055-1-n2h9z4@gmail.com>
On 04/11/2023 19:28, Nik Bune wrote:
> Convert txt file to yaml. Add maintainers from git blame.
>
> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
Thank you for your patch. There is something to discuss/improve - few nits.
> ---
> .../bindings/watchdog/nxp,pnx4008-wdt.yaml | 34 +++++++++++++++++++
> .../bindings/watchdog/pnx4008-wdt.txt | 17 ----------
> 2 files changed, 34 insertions(+), 17 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/nxp,pnx4008-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/pnx4008-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/nxp,pnx4008-wdt.yaml b/Documentation/devicetree/bindings/watchdog/nxp,pnx4008-wdt.yaml
> new file mode 100644
> index 000000000000..86b691a339b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/nxp,pnx4008-wdt.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/nxp,pnx4008-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PNX watchdog timer
> +
> +allOf:
> + - $ref: watchdog.yaml#
Put allOf: after maintainers: block. I know that many files do not
follow this convention...
> +
> +maintainers:
> + - Roland Stigge <stigge@antcom.de>
> +
> +properties:
> + compatible:
> + const: nxp,pnx4008-wdt
> +
> + reg:
> + maxItems: 1
> +
> +unevaluatedProperties: false
And this goes after required: block.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + watchdog@4003c000 {
> + compatible = "nxp,pnx4008-wdt";
> + reg = <0x4003C000 0x1000>;
Lower-case hex please.
> + timeout-sec = <10>;
> + };
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-05 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 18:28 [PATCH] dt-bindings: watchdog: nxp,pnx4008-wdt: convert txt to yaml Nik Bune
2023-11-05 18:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=894de0ea-d532-4bf3-88ae-91c766e703c5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=n2h9z4@gmail.com \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stigge@antcom.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).