From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, kernel@pengutronix.de,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/5] watchdog: txx9: Stop using module_platform_driver_probe()
Date: Mon, 6 Nov 2023 08:02:07 -0800 [thread overview]
Message-ID: <8b47d0f5-bfa8-434a-9abe-d2f7e9eae917@roeck-us.net> (raw)
In-Reply-To: <20231106154807.3866712-3-u.kleine-koenig@pengutronix.de>
On Mon, Nov 06, 2023 at 04:48:10PM +0100, Uwe Kleine-König wrote:
> On today's platforms the benefit of platform_driver_probe() isn't that
> relevant any more. It allows to drop some code after booting (or module
> loading) for .probe() and discard the .remove() function completely if
> the driver is built-in. This typically saves a few 100k.
>
> The downside of platform_driver_probe() is that the driver cannot be
> bound and unbound at runtime which is ancient and also slightly
> complicates testing. There are also thoughts to deprecate
> platform_driver_probe() because it adds some complexity in the driver
> core for little gain. Also many drivers don't use it correctly. This
> driver for example misses to mark the driver struct with __refdata which
> is needed to suppress a (W=1) modpost warning:
>
> WARNING: modpost: drivers/watchdog/txx9wdt: section mismatch in reference: txx9wdt_driver+0x4 (section: .data) -> txx9wdt_remove (section: .exit.text)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2023-11-06 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 15:48 [PATCH 0/5] watchdog: Drop platform_driver_probe() and convert to platform remove callback returning void (part II) Uwe Kleine-König
2023-11-06 15:48 ` [PATCH 1/5] watchdog: at91sam9: Stop using module_platform_driver_probe() Uwe Kleine-König
2023-11-06 16:01 ` Guenter Roeck
2023-11-07 9:19 ` Nicolas Ferre
2023-11-06 15:48 ` [PATCH 2/5] watchdog: txx9: " Uwe Kleine-König
2023-11-06 16:02 ` Guenter Roeck [this message]
2023-11-06 15:48 ` [PATCH 3/5] watchdog: at91sam9_wdt: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-06 16:02 ` Guenter Roeck
2023-11-07 9:20 ` Nicolas Ferre
2023-11-06 15:48 ` [PATCH 4/5] watchdog: starfive-wdt: " Uwe Kleine-König
2023-11-06 16:02 ` Guenter Roeck
2023-11-06 15:48 ` [PATCH 5/5] watchdog: txx9wdt: " Uwe Kleine-König
2023-11-06 16:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b47d0f5-bfa8-434a-9abe-d2f7e9eae917@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel@pengutronix.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).