From: Guenter Roeck <linux@roeck-us.net>
To: David Ober <dober@lenovo.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
David Ober <dober6023@gmail.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [External] Re: [PATCH v2] watchdog: add in watchdog for nct6686
Date: Sat, 24 Feb 2024 09:25:54 -0800 [thread overview]
Message-ID: <9d670c24-4897-4a02-87c1-98e366075e83@roeck-us.net> (raw)
In-Reply-To: <SEYPR03MB7192ED993D9A15244EF22D9FDA542@SEYPR03MB7192.apcprd03.prod.outlook.com>
On Sat, Feb 24, 2024 at 05:00:04PM +0000, David Ober wrote:
> Hi
>
> I understand the issue of the first come first grab but when I attempted to add this to the hwmon you insisted that that was not the correct place and to create a watchdog module so if both can not be loaded then would it have not been better to add it to the hwmon like some of the other chips.
>
Two options:
- Add it to the hwmon driver. Not a preferred solution.
- Implement a mfd driver which controls access to the chip
(preferrably through regmap) and instantiates both the hwmon
driver and the watchdog driver.
Guenter
prev parent reply other threads:[~2024-02-24 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:27 [PATCH v2] watchdog: add in watchdog for nct6686 David Ober
2023-12-19 20:05 ` Mark Pearson
2024-02-23 19:49 ` Mark Pearson
2024-02-24 16:19 ` Guenter Roeck
2024-02-24 17:00 ` [External] " David Ober
2024-02-24 17:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d670c24-4897-4a02-87c1-98e366075e83@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dober6023@gmail.com \
--cc=dober@lenovo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).