From: Biju Das <biju.das.jz@bp.renesas.com>
To: Conor Dooley <conor@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Steve Twiss <stwiss.opensource@diasemi.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
biju.das.au <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
Date: Mon, 4 Dec 2023 10:55:20 +0000 [thread overview]
Message-ID: <TYCPR01MB112697ABEBD60A1ADB32ECA248686A@TYCPR01MB11269.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TYCPR01MB1126961003EB5830E645742BE8687A@TYCPR01MB11269.jpnprd01.prod.outlook.com>
Hi Conor Dooley,
> Subject: RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog:
> Add fallback for DA9061 watchdog
>
> Hi Conor Dooley,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-
> watchdog:
> > Add fallback for DA9061 watchdog
> >
> > On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote:
> > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver
> > > changes are required. The fallback compatible string
> > > "dlg,da9062-watchdog" will be used on DA9061 watchdog.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > v2:
> > > * New patch
> > > ---
> > > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++--
> -
> > > 1 file changed, 8 insertions(+), 3 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l
> > > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l index f058628bb632..2b71fdb9251c 100644
> > > ---
> > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l
> > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog
> > > +++ .y
> > > +++ aml
> > > @@ -14,9 +14,14 @@ allOf:
> > >
> > > properties:
> > > compatible:
> > > - enum:
> > > - - dlg,da9061-watchdog
> > > - - dlg,da9062-watchdog
> > > + oneOf:
> > > + - items:
> > > + - enum:
> > > + - dlg,da9062-watchdog
> > > + - items:
> > > + - enum:
> > > + - dlg,da9061-watchdog
> >
> > If there is no da9064 on the horizon, I'd just make this const.
>
> You mean since it is single device having a fallback, define both device
> compatible and fallback as const instead of enum and const??
>
> >
> > > + - const: dlg,da9062-watchdog # da9062-watchdog fallback
> >
> > The comment here is just noise IMO.
Yes it make sense, comment is not needed.
oneOf:
- items:
- enum:
- dlg,da9062-watchdog
- items:
- const: dlg,da9061-watchdog
- const: dlg,da9062-watchdog
Cheers,
Biju
next prev parent reply other threads:[~2023-12-04 10:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 19:25 [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-02 19:25 ` [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-03 11:34 ` Conor Dooley
2023-12-03 12:52 ` Biju Das
2023-12-04 10:55 ` Biju Das [this message]
2023-12-04 17:10 ` Conor Dooley
2023-12-02 19:25 ` [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
2023-12-03 11:34 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB112697ABEBD60A1ADB32ECA248686A@TYCPR01MB11269.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).