From: Biju Das <biju.das.jz@bp.renesas.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Lee Jones <lee@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
Steve Twiss <stwiss.opensource@diasemi.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
biju.das.au <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
Date: Thu, 7 Dec 2023 16:41:32 +0000 [thread overview]
Message-ID: <TYCPR01MB11269D458652AC88522260268868BA@TYCPR01MB11269.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <a27c0fc9-614d-4207-b087-87b44bc38156@linaro.org>
Hi Krzysztof Kozlowski,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, December 7, 2023 8:35 AM
> Subject: Re: [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog:
> Add fallback for DA9061 watchdog
>
> On 06/12/2023 16:57, Biju Das wrote:
> > The DA9061 watchdog is identical to DA9062 watchdog, so no driver
> > changes are required. The fallback compatible string
> > "dlg,da9062-watchdog" will be used on DA9061 watchdog.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v3->v4:
> > * Dropped comment for d9061 watchdog fallback.
> > * Replaced enum->const for dlg,da9061-watchdog and its fallback.
> > v2->v3:
> > * No change
> > v2:
> > * New patch
> > ---
> > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > index f058628bb632..7c63b99dac85 100644
> > ---
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y
> > +++ aml
> > @@ -14,9 +14,13 @@ allOf:
> >
> > properties:
> > compatible:
> > - enum:
> > - - dlg,da9061-watchdog
> > - - dlg,da9062-watchdog
> > + oneOf:
> > + - items:
>
> Drop items, just enum. Easier to read so usually we keep such syntax for
> compatibles.
OK will do.
Cheers,
Biju
>
> > + - enum:
> > + - dlg,da9062-watchdog
> > + - items:
> > + - const: dlg,da9061-watchdog
> > + - const: dlg,da9062-watchdog
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-12-07 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231206155740.5278-1-biju.das.jz@bp.renesas.com>
2023-12-06 15:57 ` [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-07 8:35 ` Krzysztof Kozlowski
2023-12-07 16:41 ` Biju Das [this message]
2023-12-06 15:57 ` [PATCH v4 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB11269D458652AC88522260268868BA@TYCPR01MB11269.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).