From: Mark Brown <broonie@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/6] Support ROHM BD96801 scalable PMIC
Date: Thu, 9 May 2024 17:38:26 +0200 [thread overview]
Message-ID: <Zjzt8mOW6dO_7XNV@finisterre.sirena.org.uk> (raw)
In-Reply-To: <0674ca23-2cf2-48a6-84d3-e0936d50dd8c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Thu, May 09, 2024 at 10:03:43AM +0300, Matti Vaittinen wrote:
> On 5/9/24 08:08, Mark Brown wrote:
> > > > > > So if we arrange to supply a name when we register multiple domains
> > > > > > things should work fine?
> Thanks for the guidance Mark. The controller name is not a problem. Problem
> is that I don't see a (proper) way to supply a name for the IRQ domain which
> gets registered by regmap-IRQ. IRQ domain code picks the name for the domain
> by the device-tree node. Both of our IRQ controllers would be instantiated
> from same node => the IRQ domain will get same name => debugfs will
> conflict.
That's why I'm suggesting to add something - just put a name field in
the struct.
> My "solution" was simply dropping the ERRB IRQ from the driver (for now at
> least). I did send that as a series without 'RFC' - but made a mistake and
> restarted the versioning from v1. I am currently working with 2 other PMICs,
> one of them does also provide similar setup of two IRQ lines. Thus, I think
> being able to provide a name (suffix?) for IRQ domain when registering it
> instead of just using the name of the DT node is something I should look
> into. It's just nice to know someone else thinks it is valid approach.
Yes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-05-09 15:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 13:07 [RFC PATCH 0/6] Support ROHM BD96801 scalable PMIC Matti Vaittinen
2024-04-02 13:07 ` [RFC PATCH 1/6] dt-bindings: ROHM BD96801 PMIC regulators Matti Vaittinen
2024-04-02 13:08 ` [RFC PATCH 2/6] dt-bindings: mfd: bd96801 PMIC core Matti Vaittinen
2024-04-02 13:08 ` [RFC PATCH 3/6] mfd: support ROHM BD96801 " Matti Vaittinen
2024-04-11 14:38 ` Lee Jones
2024-04-12 5:40 ` Matti Vaittinen
2024-04-12 5:50 ` Matti Vaittinen
2024-04-12 7:23 ` Lee Jones
2024-04-12 8:58 ` Matti Vaittinen
2024-04-17 12:24 ` Lee Jones
2024-04-02 13:11 ` [RFC PATCH 5/6] watchdog: ROHM BD96801 PMIC WDG driver Matti Vaittinen
2024-04-02 16:15 ` Krzysztof Kozlowski
2024-04-02 17:11 ` Guenter Roeck
2024-04-03 6:34 ` Matti Vaittinen
2024-04-03 12:41 ` Guenter Roeck
2024-04-03 12:47 ` Matti Vaittinen
2024-04-03 13:26 ` Guenter Roeck
2024-04-02 13:12 ` [RFC PATCH 6/6] MAINTAINERS: Add ROHM BD96801 'scalable PMIC' entries Matti Vaittinen
2024-04-04 7:26 ` [RFC PATCH 0/6] Support ROHM BD96801 scalable PMIC Matti Vaittinen
2024-04-04 12:09 ` Mark Brown
2024-04-04 13:15 ` Matti Vaittinen
2024-04-05 9:19 ` Matti Vaittinen
2024-04-05 21:27 ` Mark Brown
2024-04-22 10:52 ` Matti Vaittinen
2024-05-09 5:08 ` Mark Brown
2024-05-09 7:03 ` Matti Vaittinen
2024-05-09 15:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjzt8mOW6dO_7XNV@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).