From: Guenter Roeck <linux@roeck-us.net>
To: forbidden405@outlook.com
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: watchdog: arm,sp805: document the reset signal
Date: Wed, 21 Feb 2024 04:55:36 -0800 [thread overview]
Message-ID: <b28acf81-75e6-444b-bd4b-c67f2bbd980c@roeck-us.net> (raw)
In-Reply-To: <20240221-hisi-wdt-v3-2-9642613dc2e6@outlook.com>
On Wed, Feb 21, 2024 at 07:56:42PM +0800, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> The reset signal needs to be deasserted before operation of sp805
> module. Document in the binding.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> index 7aea255b301b..bd7c09ed1938 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> @@ -50,6 +50,10 @@ properties:
> - const: wdog_clk
> - const: apb_pclk
>
> + resets:
> + maxItems: 1
> + description: WDOGRESn input reset signal for sp805 module.
> +
> required:
> - compatible
> - reg
> @@ -67,4 +71,5 @@ examples:
> interrupts = <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&wdt_clk>, <&apb_pclk>;
> clock-names = "wdog_clk", "apb_pclk";
> + resets = <&wdt_rst>;
> };
>
> --
> 2.43.0
>
prev parent reply other threads:[~2024-02-21 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:56 [PATCH v3 0/2] watchdog: sp805: add reset control support Yang Xiwen via B4 Relay
2024-02-21 11:56 ` [PATCH v3 1/2] watchdog: sp805_wdt: deassert the reset if available Yang Xiwen via B4 Relay
2024-02-21 12:28 ` Philipp Zabel
2024-02-21 12:55 ` Guenter Roeck
2024-02-21 11:56 ` [PATCH v3 2/2] dt-bindings: watchdog: arm,sp805: document the reset signal Yang Xiwen via B4 Relay
2024-02-21 12:55 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28acf81-75e6-444b-bd4b-c67f2bbd980c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vireshk@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).