From: "Saulnier, Nick" <nsaulnier@ti.com>
To: "Mendez, Judith" <jm@ti.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rafael Beims <rafael.beims@toradex.com>,
"Raghavendra, Vignesh" <vigneshr@ti.com>
Subject: RE: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin
Date: Wed, 8 May 2024 20:32:20 +0000 [thread overview]
Message-ID: <be00c7622f80474bbe4a9cffc16e3025@ti.com> (raw)
In-Reply-To: <a523cf49-4eeb-44a2-8438-c77b3c50ad15@ti.com>
Tested on my side with the default 50% window across a range of periods. Works as expected. Details at
https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1338070/am625-how-to-control-the-watchdog/5166032#5166032
Regards,
Nick Saulnier
-----Original Message-----
From: Mendez, Judith
Sent: Wednesday, May 08, 2024 1:50 PM
To: Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org; Rafael Beims <rafael.beims@toradex.com>; Raghavendra, Vignesh <vigneshr@ti.com>; Saulnier, Nick <nsaulnier@ti.com>
Subject: Re: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin
Hi all,
On 4/17/24 3:57 PM, Judith Mendez wrote:
> On AM62x, the watchdog is pet before the valid window is open. Fix
> min_hw_heartbeat and accommodate a 2% + static offset safety margin.
> The static offset accounts for max hardware error.
>
> Remove the hack in the driver which shifts the open window boundary,
> since it is no longer necessary due to the fix mentioned above.
>
This patch has been sitting and there are no comments.
Please let me know if there is any issue with this patch, since I would like to get this fix merged (:
Thanks,
Judith
prev parent reply other threads:[~2024-05-08 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 20:57 [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin Judith Mendez
2024-04-17 21:10 ` Guenter Roeck
2024-05-08 18:50 ` Judith Mendez
2024-05-08 20:32 ` Saulnier, Nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be00c7622f80474bbe4a9cffc16e3025@ti.com \
--to=nsaulnier@ti.com \
--cc=jm@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.beims@toradex.com \
--cc=vigneshr@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).